Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Issue 409603003: Refactor GuestView construction (Closed)

Created:
6 years, 5 months ago by Fady Samuel
Modified:
6 years, 5 months ago
Reviewers:
lazyboy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refactor GuestView construction Each GuestView derived type is now responsible for managing it's own construction. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284527

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -26 lines) Patch
M chrome/browser/guest_view/app_view/app_view_guest.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/guest_view/app_view/app_view_guest.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/guest_view.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/guest_view_base.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/guest_view_base.cc View 3 chunks +27 lines, -12 lines 0 comments Download
M chrome/browser/guest_view/guest_view_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/guest_view/web_view/web_view_guest.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/guest_view/web_view/web_view_guest.cc View 2 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Fady Samuel
6 years, 5 months ago (2014-07-21 17:15:31 UTC) #1
lazyboy
lgtm
6 years, 5 months ago (2014-07-21 17:33:58 UTC) #2
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 5 months ago (2014-07-21 19:06:47 UTC) #3
Fady Samuel
The CQ bit was unchecked by fsamuel@chromium.org
6 years, 5 months ago (2014-07-21 19:06:47 UTC) #4
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 5 months ago (2014-07-21 19:06:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/409603003/1
6 years, 5 months ago (2014-07-21 19:08:05 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 21:04:12 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 21:06:58 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/161275)
6 years, 5 months ago (2014-07-21 21:06:59 UTC) #9
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 5 months ago (2014-07-21 21:42:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/409603003/1
6 years, 5 months ago (2014-07-21 21:47:39 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 22:49:56 UTC) #12
Message was sent while issue was closed.
Change committed as 284527

Powered by Google App Engine
This is Rietveld 408576698