Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.cc

Issue 409603003: Refactor GuestView construction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/guest_view/web_view/web_view_guest.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/guest_view/web_view/web_view_guest.cc
diff --git a/chrome/browser/guest_view/web_view/web_view_guest.cc b/chrome/browser/guest_view/web_view/web_view_guest.cc
index e6852d29fce3b0aa4b24fd72942b20ca89263643..674d0bddb59e340e85d26e5a2bee3216e0231880 100644
--- a/chrome/browser/guest_view/web_view/web_view_guest.cc
+++ b/chrome/browser/guest_view/web_view/web_view_guest.cc
@@ -169,15 +169,10 @@ void ParsePartitionParam(const base::DictionaryValue& create_params,
} // namespace
-WebViewGuest::WebViewGuest(content::BrowserContext* browser_context,
- int guest_instance_id)
- : GuestView<WebViewGuest>(browser_context, guest_instance_id),
- pending_context_menu_request_id_(0),
- is_overriding_user_agent_(false),
- chromevox_injected_(false),
- current_zoom_factor_(1.0),
- find_helper_(this),
- javascript_dialog_helper_(this) {
+// static
+GuestViewBase* WebViewGuest::Create(content::BrowserContext* browser_context,
+ int guest_instance_id) {
+ return new WebViewGuest(browser_context, guest_instance_id);
}
// static
@@ -698,6 +693,17 @@ bool WebViewGuest::ClearData(const base::Time remove_since,
return true;
}
+WebViewGuest::WebViewGuest(content::BrowserContext* browser_context,
+ int guest_instance_id)
+ : GuestView<WebViewGuest>(browser_context, guest_instance_id),
+ pending_context_menu_request_id_(0),
+ is_overriding_user_agent_(false),
+ chromevox_injected_(false),
+ current_zoom_factor_(1.0),
+ find_helper_(this),
+ javascript_dialog_helper_(this) {
+}
+
WebViewGuest::~WebViewGuest() {
}
« no previous file with comments | « chrome/browser/guest_view/web_view/web_view_guest.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698