Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/browser/guest_view/app_view/app_view_guest.h

Issue 409603003: Refactor GuestView construction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/guest_view/app_view/app_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/guest_view/app_view/app_view_guest.h
diff --git a/chrome/browser/guest_view/app_view/app_view_guest.h b/chrome/browser/guest_view/app_view/app_view_guest.h
index 5b07fb0fd47403886bcbdf37bad222ea8c498b79..87aa89c5a9183e3b26bf8253045bffe08b36b66e 100644
--- a/chrome/browser/guest_view/app_view/app_view_guest.h
+++ b/chrome/browser/guest_view/app_view/app_view_guest.h
@@ -15,7 +15,7 @@ class ExtensionHost;
};
// An AppViewGuest provides the browser-side implementation of <appview> API.
-// AppViewGuest is created on attachment. That is, when a guest WEbContnets is
+// AppViewGuest is created on attachment. That is, when a guest WebContents is
// associated with a particular embedder WebContents. This happens on calls to
// the connect API.
class AppViewGuest : public GuestView<AppViewGuest>,
@@ -31,8 +31,8 @@ class AppViewGuest : public GuestView<AppViewGuest>,
int guest_instance_id,
const std::string& guest_extension_id);
- AppViewGuest(content::BrowserContext* browser_context,
- int guest_instance_id);
+ static GuestViewBase* Create(content::BrowserContext* browser_context,
+ int guest_instance_id);
// ExtensionFunctionDispatcher::Delegate implementation.
virtual extensions::WindowController* GetExtensionWindowController() const
@@ -58,6 +58,9 @@ class AppViewGuest : public GuestView<AppViewGuest>,
virtual void DidInitialize() OVERRIDE;
private:
+ AppViewGuest(content::BrowserContext* browser_context,
+ int guest_instance_id);
+
virtual ~AppViewGuest();
void OnRequest(const ExtensionHostMsg_Request_Params& params);
« no previous file with comments | « no previous file | chrome/browser/guest_view/app_view/app_view_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698