Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.h

Issue 409603003: Refactor GuestView construction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/web_view_guest.h
diff --git a/chrome/browser/guest_view/web_view/web_view_guest.h b/chrome/browser/guest_view/web_view/web_view_guest.h
index 5b7d0456813f1b2702a22edc48aef25f07cddee9..0150bbf46b81b0ed61a47686b70e90655f47080e 100644
--- a/chrome/browser/guest_view/web_view/web_view_guest.h
+++ b/chrome/browser/guest_view/web_view/web_view_guest.h
@@ -45,8 +45,8 @@ class SimpleMenuModel;
class WebViewGuest : public GuestView<WebViewGuest>,
public content::NotificationObserver {
public:
- WebViewGuest(content::BrowserContext* browser_context,
- int guest_instance_id);
+ static GuestViewBase* Create(content::BrowserContext* browser_context,
+ int guest_instance_id);
// For WebViewGuest, we create special guest processes, which host the
// tag content separately from the main application that embeds the tag.
@@ -238,6 +238,9 @@ class WebViewGuest : public GuestView<WebViewGuest>,
private:
friend class WebViewPermissionHelper;
+ WebViewGuest(content::BrowserContext* browser_context,
+ int guest_instance_id);
+
virtual ~WebViewGuest();
// Returns the top level items (ignoring submenus) as Value.
« no previous file with comments | « chrome/browser/guest_view/guest_view_manager.cc ('k') | chrome/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698