Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: chrome/browser/guest_view/app_view/app_view_guest.cc

Issue 409603003: Refactor GuestView construction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/guest_view/app_view/app_view_guest.h" 5 #include "chrome/browser/guest_view/app_view/app_view_guest.h"
6 6
7 #include "base/command_line.h"
7 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h" 8 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
8 #include "chrome/browser/extensions/extension_service.h" 9 #include "chrome/browser/extensions/extension_service.h"
9 #include "chrome/browser/guest_view/app_view/app_view_constants.h" 10 #include "chrome/browser/guest_view/app_view/app_view_constants.h"
10 #include "chrome/browser/guest_view/guest_view_manager.h" 11 #include "chrome/browser/guest_view/guest_view_manager.h"
11 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
12 #include "chrome/browser/renderer_context_menu/context_menu_delegate.h" 13 #include "chrome/browser/renderer_context_menu/context_menu_delegate.h"
13 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h" 14 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
15 #include "chrome/common/chrome_switches.h"
14 #include "content/public/browser/render_view_host.h" 16 #include "content/public/browser/render_view_host.h"
15 #include "content/public/common/renderer_preferences.h" 17 #include "content/public/common/renderer_preferences.h"
16 #include "extensions/browser/api/app_runtime/app_runtime_api.h" 18 #include "extensions/browser/api/app_runtime/app_runtime_api.h"
17 #include "extensions/browser/event_router.h" 19 #include "extensions/browser/event_router.h"
18 #include "extensions/browser/extension_host.h" 20 #include "extensions/browser/extension_host.h"
19 #include "extensions/browser/extension_system.h" 21 #include "extensions/browser/extension_system.h"
20 #include "extensions/browser/lazy_background_task_queue.h" 22 #include "extensions/browser/lazy_background_task_queue.h"
21 #include "extensions/browser/view_type_utils.h" 23 #include "extensions/browser/view_type_utils.h"
22 #include "extensions/common/api/app_runtime.h" 24 #include "extensions/common/api/app_runtime.h"
23 #include "extensions/common/extension_messages.h" 25 #include "extensions/common/extension_messages.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 82
81 response_info->app_view_guest-> 83 response_info->app_view_guest->
82 CompleteCreateWebContents(url, 84 CompleteCreateWebContents(url,
83 response_info->guest_extension, 85 response_info->guest_extension,
84 response_info->callback); 86 response_info->callback);
85 87
86 response_map->erase(guest_instance_id); 88 response_map->erase(guest_instance_id);
87 return true; 89 return true;
88 } 90 }
89 91
92 // static
93 GuestViewBase* AppViewGuest::Create(content::BrowserContext* browser_context,
94 int guest_instance_id) {
95 if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
96 switches::kEnableAppView)) {
97 return NULL;
98 }
99 return new AppViewGuest(browser_context, guest_instance_id);
100 }
101
90 AppViewGuest::AppViewGuest(content::BrowserContext* browser_context, 102 AppViewGuest::AppViewGuest(content::BrowserContext* browser_context,
91 int guest_instance_id) 103 int guest_instance_id)
92 : GuestView<AppViewGuest>(browser_context, guest_instance_id), 104 : GuestView<AppViewGuest>(browser_context, guest_instance_id),
93 weak_ptr_factory_(this) { 105 weak_ptr_factory_(this) {
94 } 106 }
95 107
96 AppViewGuest::~AppViewGuest() { 108 AppViewGuest::~AppViewGuest() {
97 } 109 }
98 110
99 extensions::WindowController* AppViewGuest::GetExtensionWindowController() 111 extensions::WindowController* AppViewGuest::GetExtensionWindowController()
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 return; 253 return;
242 } 254 }
243 255
244 scoped_ptr<base::DictionaryValue> embed_request(new base::DictionaryValue()); 256 scoped_ptr<base::DictionaryValue> embed_request(new base::DictionaryValue());
245 embed_request->SetInteger(appview::kGuestInstanceID, GetGuestInstanceID()); 257 embed_request->SetInteger(appview::kGuestInstanceID, GetGuestInstanceID());
246 embed_request->SetString(appview::kEmbedderID, embedder_extension_id()); 258 embed_request->SetString(appview::kEmbedderID, embedder_extension_id());
247 extensions::AppRuntimeEventRouter::DispatchOnEmbedRequestedEvent( 259 extensions::AppRuntimeEventRouter::DispatchOnEmbedRequestedEvent(
248 profile, embed_request.Pass(), extension_host->extension()); 260 profile, embed_request.Pass(), extension_host->extension());
249 } 261 }
250 262
OLDNEW
« no previous file with comments | « chrome/browser/guest_view/app_view/app_view_guest.h ('k') | chrome/browser/guest_view/guest_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698