Issue 405283002: Try to re-land portion of FailureValue patch (399263003) that should

Issue 405283002: Try to re-land portion of FailureValue patch (399263003) that should (Closed)

Created:
6 years, 5 months ago by chrishenry

Modified:
6 years, 5 months ago

Reviewers:
nednguyen

CC:
chromium-reviews, telemetry+watch_chromium.org, eakuefner

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Try to re-land portion of FailureValue patch (399263003) that should be safe to land. Mainly adding FailureValue but not wiring it via PageTestResults/GTestTestResults/PageRunner yet. The remaining change will be landed separately to better isolate the problem that caused it to be reverted. BUG=392901 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284704

Patch Set 1 : #

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -13 lines)			Patch
M	tools/telemetry/telemetry/page/profile_generator.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/record_wpr.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/results/block_page_measurement_results.py	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	tools/telemetry/telemetry/results/buildbot_page_measurement_results.py	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/results/gtest_test_results.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/results/page_measurement_results.py	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/results/page_test_results.py	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
A	tools/telemetry/telemetry/value/failure.py	View		1 chunk	+83 lines, -0 lines	0 comments	Download
A	tools/telemetry/telemetry/value/failure_unittest.py	View		1 chunk	+44 lines, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/value/merge_values.py	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/value/summary.py	View		2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/405283002/40001

6 years, 5 months ago (2014-07-22 14:46:12 UTC) #4

Message was sent while issue was closed.

Change committed as 284704

Expand Messages | Collapse Messages