tools/telemetry/telemetry/results/buildbot_page_measurement_results.py - Issue 405283002: Try to re-land portion of FailureValue patch (399263003) that should

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/buildbot_page_measurement_results.py

Issue 405283002: Try to re-land portion of FailureValue patch (399263003) that should (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/block_page_measurement_results.py ('k') | tools/telemetry/telemetry/results/gtest_test_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/buildbot_page_measurement_results.py

diff --git a/tools/telemetry/telemetry/results/buildbot_page_measurement_results.py b/tools/telemetry/telemetry/results/buildbot_page_measurement_results.py

index fef9933830a4a2fe53d7da775a2cb73c6814061d..6e9b698da0924e652d5ac5bea9b5f297dbacd7a1 100644

--- a/tools/telemetry/telemetry/results/buildbot_page_measurement_results.py

+++ b/tools/telemetry/telemetry/results/buildbot_page_measurement_results.py

@@ -52,6 +52,9 @@ class BuildbotPageMeasurementResults(

buildbot_value = value.GetBuildbotValue()

buildbot_data_type = value.GetBuildbotDataType(

output_context=value_module.PER_PAGE_RESULT_OUTPUT_CONTEXT)

+ if buildbot_value is None or buildbot_data_type is None:

+ return

buildbot_measurement_name, buildbot_trace_name = (

value.GetBuildbotMeasurementAndTraceNameForPerPageResult())

self._PrintPerfResult(buildbot_measurement_name,

@@ -68,10 +71,12 @@ class BuildbotPageMeasurementResults(

buildbot_value = value.GetBuildbotValue()

buildbot_data_type = value.GetBuildbotDataType(

output_context=value_module.COMPUTED_PER_PAGE_SUMMARY_OUTPUT_CONTEXT)

+ if buildbot_value is None or buildbot_data_type is None:

+ return

buildbot_measurement_name, buildbot_trace_name = (

value.GetBuildbotMeasurementAndTraceNameForComputedSummaryResult(

self._trace_tag))

self._PrintPerfResult(buildbot_measurement_name,

buildbot_trace_name,

buildbot_value, value.units, buildbot_data_type)