Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: tools/telemetry/telemetry/value/merge_values.py

Issue 405283002: Try to re-land portion of FailureValue patch (399263003) that should (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/value/failure_unittest.py ('k') | tools/telemetry/telemetry/value/summary.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/merge_values.py
diff --git a/tools/telemetry/telemetry/value/merge_values.py b/tools/telemetry/telemetry/value/merge_values.py
index 30c999db8648d4f9b7f10366df7e31935be407d4..89d187824e19fd7e5bb7a45083cae1f6e45f3e0d 100644
--- a/tools/telemetry/telemetry/value/merge_values.py
+++ b/tools/telemetry/telemetry/value/merge_values.py
@@ -1,6 +1,9 @@
# Copyright 2013 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+
+from telemetry.value import failure
+
def MergeLikeValuesFromSamePage(all_values):
"""Merges values that measure the same thing on the same page.
@@ -108,6 +111,12 @@ def GroupStably(all_values, key_func):
merge_groups = {}
merge_groups_in_creation_order = []
for value in all_values:
+ # TODO(chrishenry): This is temporary. When we figure out the
+ # right summarization strategy for page runs with failures, we
+ # should use that instead.
+ if isinstance(value, failure.FailureValue):
+ continue
+
key = key_func(value)
if key not in merge_groups:
merge_groups[key] = []
« no previous file with comments | « tools/telemetry/telemetry/value/failure_unittest.py ('k') | tools/telemetry/telemetry/value/summary.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698