Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: tools/telemetry/telemetry/results/page_test_results.py

Issue 405283002: Try to re-land portion of FailureValue patch (399263003) that should (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import collections 5 import collections
6 import copy 6 import copy
7 import logging 7 import logging
8 import sys 8 import sys
9 import traceback 9 import traceback
10 10
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 def _GetStringFromExcInfo(self, err): 49 def _GetStringFromExcInfo(self, err):
50 return ''.join(traceback.format_exception(*err)) 50 return ''.join(traceback.format_exception(*err))
51 51
52 def StartTest(self, page): 52 def StartTest(self, page):
53 pass 53 pass
54 54
55 def StopTest(self, page): 55 def StopTest(self, page):
56 pass 56 pass
57 57
58 def AddValue(self, value): 58 def AddValue(self, value):
59 self.ValidateValue(value) 59 self._ValidateValue(value)
60 self._all_page_specific_values.append(value) 60 self._all_page_specific_values.append(value)
61 61
62 def AddSummaryValue(self, value): 62 def AddSummaryValue(self, value):
63 assert value.page is None 63 assert value.page is None
64 self.ValidateValue(value) 64 self._ValidateValue(value)
65 self._all_summary_values.append(value) 65 self._all_summary_values.append(value)
66 66
67 def ValidateValue(self, value): 67 def _ValidateValue(self, value):
68 assert isinstance(value, value_module.Value) 68 assert isinstance(value, value_module.Value)
69 if value.name not in self._representative_value_for_each_value_name: 69 if value.name not in self._representative_value_for_each_value_name:
70 self._representative_value_for_each_value_name[value.name] = value 70 self._representative_value_for_each_value_name[value.name] = value
71 representative_value = self._representative_value_for_each_value_name[ 71 representative_value = self._representative_value_for_each_value_name[
72 value.name] 72 value.name]
73 assert value.IsMergableWith(representative_value) 73 assert value.IsMergableWith(representative_value)
74 74
75 def AddFailure(self, page, err): 75 def AddFailure(self, page, err):
76 self.pages_that_had_failures.add(page) 76 self.pages_that_had_failures.add(page)
77 self.failures.append((page, self._GetStringFromExcInfo(err))) 77 self.failures.append((page, self._GetStringFromExcInfo(err)))
(...skipping 25 matching lines...) Expand all
103 if value.page == page and value.name == value_name: 103 if value.page == page and value.name == value_name:
104 values.append(value) 104 values.append(value)
105 return values 105 return values
106 106
107 def FindAllPageSpecificValuesNamed(self, value_name): 107 def FindAllPageSpecificValuesNamed(self, value_name):
108 values = [] 108 values = []
109 for value in self.all_page_specific_values: 109 for value in self.all_page_specific_values:
110 if value.name == value_name: 110 if value.name == value_name:
111 values.append(value) 111 values.append(value)
112 return values 112 return values
OLDNEW
« no previous file with comments | « tools/telemetry/telemetry/results/page_measurement_results.py ('k') | tools/telemetry/telemetry/value/failure.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698