tools/telemetry/telemetry/page/record_wpr.py - Issue 405283002: Try to re-land portion of FailureValue patch (399263003) that should

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/record_wpr.py

Issue 405283002: Try to re-land portion of FailureValue patch (399263003) that should (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/profile_generator.py ('k') | tools/telemetry/telemetry/results/block_page_measurement_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/record_wpr.py

diff --git a/tools/telemetry/telemetry/page/record_wpr.py b/tools/telemetry/telemetry/page/record_wpr.py

index 4f9bf585c5fbb48dd872119664637ba005ae5340..9491e4d9a8280ef57263c2bb12f2e42089b6dd72 100755

--- a/tools/telemetry/telemetry/page/record_wpr.py

+++ b/tools/telemetry/telemetry/page/record_wpr.py

@@ -136,7 +136,7 @@ def Main(base_dir):

logging.warning('Some pages failed. The recording has not been updated for '

'these pages.')

logging.warning('Failed pages:\n%s', '\n'.join(

- p.display_name for p in zip(*results.failures)[0]))

+ p.display_name for p in results.pages_that_had_failures))

if results.skipped:

logging.warning('Some pages were skipped. The recording has not been '