Refactor texture compressors into separate files

Refactor texture compressors into separate files

Committed: https://skia.googlesource.com/skia/+/6c354881b63935626a0700366937530d38b8b1e8

[robertphillips, 2014-07-21 21:56:57]

lgtm + nits

https://codereview.chromium.org/403383003/diff/1/src/utils/SkTextureCompresso...
File src/utils/SkTextureCompressor.cpp (right):

https://codereview.chromium.org/403383003/diff/1/src/utils/SkTextureCompresso...
src/utils/SkTextureCompressor.cpp:104: switch(format) {
default at bottom ?

https://codereview.chromium.org/403383003/diff/1/src/utils/SkTextureCompressor.h
File src/utils/SkTextureCompressor.h (right):

https://codereview.chromium.org/403383003/diff/1/src/utils/SkTextureCompresso...
src/utils/SkTextureCompressor.h:51: 
"the a" ?

https://codereview.chromium.org/403383003/diff/1/src/utils/SkTextureCompresso...
File src/utils/SkTextureCompressor_R11EAC.cpp (right):

https://codereview.chromium.org/403383003/diff/1/src/utils/SkTextureCompresso...
src/utils/SkTextureCompressor_R11EAC.cpp:269: // of 8-bit alpha into 64-bit
values that comprise the compressed data.
both formats ?

https://codereview.chromium.org/403383003/diff/1/src/utils/SkTextureCompresso...
src/utils/SkTextureCompressor_R11EAC.cpp:901: *outPtr =
compress_block_vertical(c[0], c[1], c[2], c[3]);
Why not pass the pointer into compress_block_vertical too?

[krajcevski, 2014-07-21 22:02:16]

The CQ bit was checked by krajcevski@google.com

[commit-bot: I haz the power, 2014-07-21 22:02:47]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/krajcevski@google.com/403383003/20001

[krajcevski, 2014-07-21 22:03:55]

https://codereview.chromium.org/403383003/diff/1/src/utils/SkTextureCompresso...
File src/utils/SkTextureCompressor.cpp (right):

https://codereview.chromium.org/403383003/diff/1/src/utils/SkTextureCompresso...
src/utils/SkTextureCompressor.cpp:104: switch(format) {
On 2014/07/21 21:56:57, robertphillips wrote:
> default at bottom ?

Done.

https://codereview.chromium.org/403383003/diff/1/src/utils/SkTextureCompressor.h
File src/utils/SkTextureCompressor.h (right):

https://codereview.chromium.org/403383003/diff/1/src/utils/SkTextureCompresso...
src/utils/SkTextureCompressor.h:51: 
On 2014/07/21 21:56:57, robertphillips wrote:
> "the a" ?

Done.

https://codereview.chromium.org/403383003/diff/1/src/utils/SkTextureCompresso...
File src/utils/SkTextureCompressor_R11EAC.cpp (right):

https://codereview.chromium.org/403383003/diff/1/src/utils/SkTextureCompresso...
src/utils/SkTextureCompressor_R11EAC.cpp:269: // of 8-bit alpha into 64-bit
values that comprise the compressed data.
On 2014/07/21 21:56:57, robertphillips wrote:
> both formats ?

Done.

https://codereview.chromium.org/403383003/diff/1/src/utils/SkTextureCompresso...
src/utils/SkTextureCompressor_R11EAC.cpp:901: *outPtr =
compress_block_vertical(c[0], c[1], c[2], c[3]);
On 2014/07/21 21:56:57, robertphillips wrote:
> Why not pass the pointer into compress_block_vertical too?

I tried that, it seemed like it was a tad slower, albeit within margin of error.
Not sure why.

[krajcevski, 2014-07-21 22:08:28]

The CQ bit was checked by krajcevski@google.com

[commit-bot: I haz the power, 2014-07-21 22:08:33]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/krajcevski@google.com/403383003/40001

[commit-bot: I haz the power, 2014-07-21 22:18:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-...)

[commit-bot: I haz the power, 2014-07-21 22:28:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-21 22:28:52]

Try jobs failed on following builders:
  Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-...)

[krajcevski, 2014-07-22 14:33:09]

The CQ bit was checked by krajcevski@google.com

[commit-bot: I haz the power, 2014-07-22 14:33:24]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/krajcevski@google.com/403383003/50001

[commit-bot: I haz the power, 2014-07-22 14:44:15]

Change committed as 6c354881b63935626a0700366937530d38b8b1e8