Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 403043004: [Ozone-DRI] Remove unneeded wrappers (Closed)

Created:
6 years, 5 months ago by dnicoara
Modified:
6 years, 5 months ago
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Ozone-DRI] Remove unneeded wrappers * Merging DriSurfaceAdaptor into DriSurface * Merging GbmSurfaceAdaptor into GbmSurface * Extracting GbmSurfaceless implementation into separate class & having GbmSurface extend it * Remove ScanoutSurface Depends on https://codereview.chromium.org/393233005 BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284710

Patch Set 1 #

Total comments: 6

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -544 lines) Patch
M ui/ozone/platform/dri/dri.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface.h View 1 chunk +20 lines, -23 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface.cc View 1 1 chunk +62 lines, -39 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory.cc View 4 chunks +4 lines, -88 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory_unittest.cc View 1 1 chunk +0 lines, -43 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface_unittest.cc View 3 chunks +48 lines, -34 lines 0 comments Download
M ui/ozone/platform/dri/gbm.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surface.h View 2 chunks +16 lines, -33 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surface.cc View 3 chunks +39 lines, -69 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surface_factory.cc View 1 2 chunks +18 lines, -125 lines 0 comments Download
A ui/ozone/platform/dri/gbm_surfaceless.h View 1 chunk +48 lines, -0 lines 0 comments Download
A ui/ozone/platform/dri/gbm_surfaceless.cc View 1 1 chunk +65 lines, -0 lines 0 comments Download
D ui/ozone/platform/dri/scanout_surface.h View 1 chunk +0 lines, -87 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dnicoara
PTAL Last CL for the refactor. This makes everything prettier.
6 years, 5 months ago (2014-07-19 00:10:32 UTC) #1
alexst (slow to review)
lgtm https://codereview.chromium.org/403043004/diff/1/ui/ozone/platform/dri/dri_surface.cc File ui/ozone/platform/dri/dri_surface.cc (right): https://codereview.chromium.org/403043004/diff/1/ui/ozone/platform/dri/dri_surface.cc#newcode26 ui/ozone/platform/dri/dri_surface.cc:26: CHECK(buffer->Initialize(info)) << "Failed to create drm buffer"; nit: ...
6 years, 5 months ago (2014-07-22 12:45:09 UTC) #2
dnicoara
https://codereview.chromium.org/403043004/diff/1/ui/ozone/platform/dri/dri_surface.cc File ui/ozone/platform/dri/dri_surface.cc (right): https://codereview.chromium.org/403043004/diff/1/ui/ozone/platform/dri/dri_surface.cc#newcode26 ui/ozone/platform/dri/dri_surface.cc:26: CHECK(buffer->Initialize(info)) << "Failed to create drm buffer"; On 2014/07/22 ...
6 years, 5 months ago (2014-07-22 14:05:46 UTC) #3
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 5 months ago (2014-07-22 16:56:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/403043004/20001
6 years, 5 months ago (2014-07-22 16:57:34 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 16:59:21 UTC) #6
Message was sent while issue was closed. 
Change committed as 284710

Powered by Google App Engine
This is Rietveld 408576698