[Ozone-DRI] Convert HardwareDisplayController to use scanout buffers

[Ozone-DRI] Convert HardwareDisplayController to use scanout buffers

This change allows scanout buffers to be kept alive until the last of
SurfaceOzone{Canvas,EGL} and HardwareDisplayController are destroyed. For
HardwareDisplayController this means that buffers will be kept around
until the CRTC is properly restored. For SurfaceOzoneEGL this means that
on monitor disconnects (HDC is destroyed) the buffers are kept alive for
any remaining EGL operations still happening.

BUG=none
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284708

[dnicoara, 2014-07-19 00:09:50]

PTAL

Second last CL for the refactor. This CL converts HDC to its final form and
since HDC no longer owns the surface, the ownership is moved into the adapters.

In order to keep the CL size small https://codereview.chromium.org/403043004/
deals with merging DriSurface with DriSurfaceAdapter (and similarly for GBM).

[alexst (slow to review), 2014-07-21 20:56:24]

https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/dr...
File ui/ozone/platform/dri/dri_surface_factory_unittest.cc (right):

https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/dr...
ui/ozone/platform/dri/dri_surface_factory_unittest.cc:24: const drmModeModeInfo
kDefaultMode =
So I was trying to understand what the code below does and while it's not part
of this particular CL, it would help others who go spelunking into this test to
understand what fields the magic values map to.

For example, what size is our hdisplay? It's hard to tell without looking at
drm.

https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/ha...
File ui/ozone/platform/dri/hardware_display_controller.cc (right):

https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/ha...
ui/ozone/platform/dri/hardware_display_controller.cc:201: 
Please remove extra whitespace unless you think it really adds to clarity.

https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/ha...
File ui/ozone/platform/dri/hardware_display_controller.h (right):

https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/ha...
ui/ozone/platform/dri/hardware_display_controller.h:28:
OverlayPlane(scoped_refptr<ScanoutBuffer> buffer);
explicit

[dnicoara, 2014-07-21 21:02:12]

https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/dr...
File ui/ozone/platform/dri/dri_surface_factory_unittest.cc (right):

https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/dr...
ui/ozone/platform/dri/dri_surface_factory_unittest.cc:24: const drmModeModeInfo
kDefaultMode =
On 2014/07/21 20:56:24, alexst wrote:
> So I was trying to understand what the code below does and while it's not part
> of this particular CL, it would help others who go spelunking into this test
to
> understand what fields the magic values map to.
> 
> For example, what size is our hdisplay? It's hard to tell without looking at
> drm.

Done.

https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/ha...
File ui/ozone/platform/dri/hardware_display_controller.cc (right):

https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/ha...
ui/ozone/platform/dri/hardware_display_controller.cc:201: 
On 2014/07/21 20:56:24, alexst wrote:
> Please remove extra whitespace unless you think it really adds to clarity.

Done.

https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/ha...
File ui/ozone/platform/dri/hardware_display_controller.h (right):

https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/ha...
ui/ozone/platform/dri/hardware_display_controller.h:28:
OverlayPlane(scoped_refptr<ScanoutBuffer> buffer);
On 2014/07/21 20:56:24, alexst wrote:
> explicit

Done.

[alexst (slow to review), 2014-07-22 12:33:16]

lgtm with a nit.

https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/dr...
File ui/ozone/platform/dri/dri_surface_factory_unittest.cc (right):

https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/dr...
ui/ozone/platform/dri/dri_surface_factory_unittest.cc:24: const drmModeModeInfo
kDefaultMode =
I meant please annotate all the fields so next person knows what the magic
numbers mean.

[dnicoara, 2014-07-22 13:51:30]

https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/dr...
File ui/ozone/platform/dri/dri_surface_factory_unittest.cc (right):

https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/dr...
ui/ozone/platform/dri/dri_surface_factory_unittest.cc:24: const drmModeModeInfo
kDefaultMode =
On 2014/07/22 12:33:16, alexst wrote:
> I meant please annotate all the fields so next person knows what the magic
> numbers mean.

Ah, sorry, I misunderstood your comment.

I don't think it makes sense to annotate all the fields given that only 2 fields
are actually initialized to used values. I'd prefer the reader to go to the
header file since that would contain more details.

[alexst (slow to review), 2014-07-22 16:41:21]

On 2014/07/22 13:51:30, dnicoara wrote:
>
https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/dr...
> File ui/ozone/platform/dri/dri_surface_factory_unittest.cc (right):
> 
>
https://codereview.chromium.org/393233005/diff/20001/ui/ozone/platform/dri/dr...
> ui/ozone/platform/dri/dri_surface_factory_unittest.cc:24: const
drmModeModeInfo
> kDefaultMode =
> On 2014/07/22 12:33:16, alexst wrote:
> > I meant please annotate all the fields so next person knows what the magic
> > numbers mean.
> 
> Ah, sorry, I misunderstood your comment.
> 
> I don't think it makes sense to annotate all the fields given that only 2
fields
> are actually initialized to used values. I'd prefer the reader to go to the
> header file since that would contain more details.

fair enough, still lgtm.

[dnicoara, 2014-07-22 16:45:58]

The CQ bit was checked by dnicoara@chromium.org

[commit-bot: I haz the power, 2014-07-22 16:46:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dnicoara@chromium.org/393233005/40001

[commit-bot: I haz the power, 2014-07-22 16:48:18]

Change committed as 284708