Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 399433005: Extirpate CreateBooleanValue. (Closed)

Created:
6 years, 5 months ago by Evan Stade
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cc-bugs_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Extirpate CreateBooleanValue. BUG=160586 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283619

Patch Set 1 #

Patch Set 2 : fix mac_util #

Patch Set 3 : s/boolean/bool #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -21 lines) Patch
M cc/layers/nine_patch_layer_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/policy/core/browser/autofill_policy_handler.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M components/policy/core/common/mac_util.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M components/policy/core/common/registry_dict_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/tools/generate_policy_source.py View 1 chunk +1 line, -1 line 0 comments Download
M components/pref_registry/pref_registry_syncable.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M extensions/browser/extension_prefs.cc View 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Evan Stade
ajuma: cc/layers/nine_patch_layer_impl.cc koz: extensions/browser/extension_prefs.cc mnissler: components/*
6 years, 5 months ago (2014-07-15 22:05:56 UTC) #1
Evan Stade
-mnissler +bartfab for policy +bauerb for pref_registry
6 years, 5 months ago (2014-07-15 22:11:50 UTC) #2
ajuma
cc lgtm
6 years, 5 months ago (2014-07-15 22:54:15 UTC) #3
Bernhard Bauer
pref_registry LGTM.
6 years, 5 months ago (2014-07-16 08:08:11 UTC) #4
bartfab (slow)
policy LGTM
6 years, 5 months ago (2014-07-16 09:03:12 UTC) #5
Evan Stade
-koz, +kalman for extensions/browser/extension_prefs.cc
6 years, 5 months ago (2014-07-16 21:23:32 UTC) #6
Evan Stade
+groby for the mac_util file
6 years, 5 months ago (2014-07-16 21:31:35 UTC) #7
not at google - send to devlin
lgtm
6 years, 5 months ago (2014-07-16 22:52:04 UTC) #8
groby-ooo-7-16
LGTM
6 years, 5 months ago (2014-07-16 23:17:48 UTC) #9
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-17 00:41:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/399433005/40001
6 years, 5 months ago (2014-07-17 00:44:40 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 03:04:47 UTC) #12
Message was sent while issue was closed.
Change committed as 283619

Powered by Google App Engine
This is Rietveld 408576698