components/policy/tools/generate_policy_source.py - Issue 399433005: Extirpate CreateBooleanValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/tools/generate_policy_source.py

Issue 399433005: Extirpate CreateBooleanValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: s/boolean/bool Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/tools/generate_policy_source.py

diff --git a/components/policy/tools/generate_policy_source.py b/components/policy/tools/generate_policy_source.py

index 4fbd2d03f9ca2ee9dba3e818a9a712dd2013d73f..b8bd42580d75e2898e90ec6a9b4ab750ca6cd2ca 100755

--- a/components/policy/tools/generate_policy_source.py

+++ b/components/policy/tools/generate_policy_source.py

@@ -856,7 +856,7 @@ CPP_FOOT = '''}

def _CreateValue(type, arg):

if type == 'TYPE_BOOLEAN':

- return 'base::Value::CreateBooleanValue(%s)' % arg

+ return 'new base::FundamentalValue(%s)' % arg

elif type == 'TYPE_INTEGER':

return 'DecodeIntegerValue(%s)' % arg

elif type == 'TYPE_STRING':