Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: components/policy/core/common/mac_util.cc

Issue 399433005: Extirpate CreateBooleanValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: s/boolean/bool Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/policy/core/common/mac_util.h" 5 #include "components/policy/core/common/mac_util.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/mac/foundation_util.h" 9 #include "base/mac/foundation_util.h"
10 #include "base/strings/sys_string_conversions.h" 10 #include "base/strings/sys_string_conversions.h"
(...skipping 30 matching lines...) Expand all
41 static_cast<base::ListValue *>(context)->Append(converted.release()); 41 static_cast<base::ListValue *>(context)->Append(converted.release());
42 } 42 }
43 43
44 } // namespace 44 } // namespace
45 45
46 scoped_ptr<base::Value> PropertyToValue(CFPropertyListRef property) { 46 scoped_ptr<base::Value> PropertyToValue(CFPropertyListRef property) {
47 if (CFCast<CFNullRef>(property)) 47 if (CFCast<CFNullRef>(property))
48 return scoped_ptr<base::Value>(base::Value::CreateNullValue()); 48 return scoped_ptr<base::Value>(base::Value::CreateNullValue());
49 49
50 if (CFBooleanRef boolean = CFCast<CFBooleanRef>(property)) { 50 if (CFBooleanRef boolean = CFCast<CFBooleanRef>(property)) {
51 return scoped_ptr<base::Value>( 51 return scoped_ptr<base::Value>(new base::FundamentalValue(
52 base::Value::CreateBooleanValue(CFBooleanGetValue(boolean))); 52 static_cast<bool>(CFBooleanGetValue(boolean))));
53 } 53 }
54 54
55 if (CFNumberRef number = CFCast<CFNumberRef>(property)) { 55 if (CFNumberRef number = CFCast<CFNumberRef>(property)) {
56 // CFNumberGetValue() converts values implicitly when the conversion is not 56 // CFNumberGetValue() converts values implicitly when the conversion is not
57 // lossy. Check the type before trying to convert. 57 // lossy. Check the type before trying to convert.
58 if (CFNumberIsFloatType(number)) { 58 if (CFNumberIsFloatType(number)) {
59 double double_value = 0.0; 59 double double_value = 0.0;
60 if (CFNumberGetValue(number, kCFNumberDoubleType, &double_value)) { 60 if (CFNumberGetValue(number, kCFNumberDoubleType, &double_value)) {
61 return scoped_ptr<base::Value>( 61 return scoped_ptr<base::Value>(
62 base::Value::CreateDoubleValue(double_value)); 62 base::Value::CreateDoubleValue(double_value));
(...skipping 24 matching lines...) Expand all
87 CFRangeMake(0, CFArrayGetCount(array)), 87 CFRangeMake(0, CFArrayGetCount(array)),
88 ArrayEntryToValue, 88 ArrayEntryToValue,
89 list_value.get()); 89 list_value.get());
90 return list_value.PassAs<base::Value>(); 90 return list_value.PassAs<base::Value>();
91 } 91 }
92 92
93 return scoped_ptr<base::Value>(); 93 return scoped_ptr<base::Value>();
94 } 94 }
95 95
96 } // namespace policy 96 } // namespace policy
OLDNEW
« no previous file with comments | « components/policy/core/browser/autofill_policy_handler.cc ('k') | components/policy/core/common/registry_dict_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698