Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: components/pref_registry/pref_registry_syncable.cc

Issue 399433005: Extirpate CreateBooleanValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: s/boolean/bool Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/policy/tools/generate_policy_source.py ('k') | extensions/browser/extension_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/pref_registry/pref_registry_syncable.cc
diff --git a/components/pref_registry/pref_registry_syncable.cc b/components/pref_registry/pref_registry_syncable.cc
index 675b30915529723ab0a679211ce2c9874f18a8dc..1cdc77c5214285053b53c9d6b98bcd8dab20e6d4 100644
--- a/components/pref_registry/pref_registry_syncable.cc
+++ b/components/pref_registry/pref_registry_syncable.cc
@@ -25,9 +25,9 @@ base::Value* CreateLocaleDefaultValue(base::Value::Type type,
switch (type) {
case base::Value::TYPE_BOOLEAN: {
if ("true" == resource_string)
- return base::Value::CreateBooleanValue(true);
+ return new base::FundamentalValue(true);
if ("false" == resource_string)
- return base::Value::CreateBooleanValue(false);
+ return new base::FundamentalValue(false);
break;
}
@@ -77,9 +77,8 @@ void PrefRegistrySyncable::SetSyncableRegistrationCallback(
void PrefRegistrySyncable::RegisterBooleanPref(const char* path,
bool default_value,
PrefSyncStatus sync_status) {
- RegisterSyncablePreference(path,
- base::Value::CreateBooleanValue(default_value),
- sync_status);
+ RegisterSyncablePreference(
+ path, new base::FundamentalValue(default_value), sync_status);
}
void PrefRegistrySyncable::RegisterIntegerPref(const char* path,
« no previous file with comments | « components/policy/tools/generate_policy_source.py ('k') | extensions/browser/extension_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698