components/policy/core/common/mac_util.cc - Issue 399433005: Extirpate CreateBooleanValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/mac_util.cc

Issue 399433005: Extirpate CreateBooleanValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: s/boolean/bool Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/common/mac_util.cc

diff --git a/components/policy/core/common/mac_util.cc b/components/policy/core/common/mac_util.cc

index 16606905ea834cc49903db8cbe7b9001fbc2fbef..cdb26cbd07f0ff18d75383362528c88aee86c755 100644

--- a/components/policy/core/common/mac_util.cc

+++ b/components/policy/core/common/mac_util.cc

@@ -48,8 +48,8 @@ scoped_ptr<base::Value> PropertyToValue(CFPropertyListRef property) {

return scoped_ptr<base::Value>(base::Value::CreateNullValue());

if (CFBooleanRef boolean = CFCast<CFBooleanRef>(property)) {

- return scoped_ptr<base::Value>(

- base::Value::CreateBooleanValue(CFBooleanGetValue(boolean)));

+ return scoped_ptr<base::Value>(new base::FundamentalValue(

+ static_cast<bool>(CFBooleanGetValue(boolean))));

}

if (CFNumberRef number = CFCast<CFNumberRef>(property)) {