DevTools: move events array from Timeline.stop response to Timeline.stopped

DevTools: move events array from Timeline.stop response to Timeline.stopped

It is a change in protocol.json.
events was a hidden property in the Timeline.stop command result.
Now it is the hidden property in Timeline.stopped event.

BUG=394780
R=alph@chromium.org, yurys@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178670

[alph, 2014-07-18 10:47:44]

https://codereview.chromium.org/397813006/diff/1/Source/devtools/front_end/sd...
File Source/devtools/front_end/sdk/TimelineManager.js (right):

https://codereview.chromium.org/397813006/diff/1/Source/devtools/front_end/sd...
Source/devtools/front_end/sdk/TimelineManager.js:213:
this._manager._processBufferedEvents(events);
Perhaps it's better to processBufferedEvents before dispatching TimelineStopped
event. wdyt?

https://codereview.chromium.org/397813006/diff/1/Source/devtools/protocol.json
File Source/devtools/protocol.json (right):

https://codereview.chromium.org/397813006/diff/1/Source/devtools/protocol.jso...
Source/devtools/protocol.json:2930: { "name": "events", "type": "array",
"items": { "$ref": "TimelineEvent" }, "optional": true, "hidden": true,
"description": "Timeline event record data." }
We could consider making eventRecorded to allow passing several events instead
of burdening stopped event.

[loislo, 2014-07-18 11:42:24]

https://codereview.chromium.org/397813006/diff/1/Source/devtools/front_end/sd...
File Source/devtools/front_end/sdk/TimelineManager.js (right):

https://codereview.chromium.org/397813006/diff/1/Source/devtools/front_end/sd...
Source/devtools/front_end/sdk/TimelineManager.js:213:
this._manager._processBufferedEvents(events);
On 2014/07/18 10:47:43, alph wrote:
> Perhaps it's better to processBufferedEvents before dispatching
TimelineStopped
> event. wdyt?

When we start the timeline we may specify a filter for the event types which
will be sent to the front_end unbuffered. So when stopped event arrives we need
to remove such the events (reset the model) and process the buffered events.

https://codereview.chromium.org/397813006/diff/1/Source/devtools/protocol.json
File Source/devtools/protocol.json (right):

https://codereview.chromium.org/397813006/diff/1/Source/devtools/protocol.jso...
Source/devtools/protocol.json:2930: { "name": "events", "type": "array",
"items": { "$ref": "TimelineEvent" }, "optional": true, "hidden": true,
"description": "Timeline event record data." }
On 2014/07/18 10:47:44, alph wrote:
> We could consider making eventRecorded to allow passing several events instead
> of burdening stopped event.

I think it doesn't matter in general because we are moving to tracing.

[alph, 2014-07-18 12:21:39]

lgtm

[loislo, 2014-07-18 12:21:47]

The CQ bit was checked by loislo@chromium.org

[commit-bot: I haz the power, 2014-07-18 12:21:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/loislo@chromium.org/397813006/1

[commit-bot: I haz the power, 2014-07-18 13:22:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[commit-bot: I haz the power, 2014-07-18 13:25:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 13:25:09]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[yurys, 2014-07-21 11:42:46]

lgtm

[loislo, 2014-07-22 15:40:09]

Committed patchset #1 manually as r178670 (presubmit successful).