Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: LayoutTests/inspector-protocol/timeline/timeline-start-bufferEvents.html

Issue 397813006: DevTools: move events array from Timeline.stop response to Timeline.stopped (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/inspector-protocol/timeline/timeline-start-bufferEvents.html
diff --git a/LayoutTests/inspector-protocol/timeline/timeline-start-bufferEvents.html b/LayoutTests/inspector-protocol/timeline/timeline-start-bufferEvents.html
index 3a4e476470472adcf28c20e3b863e9d4d57b2955..5145bc73e99af8e312197976a55aadc7b3a26286 100644
--- a/LayoutTests/inspector-protocol/timeline/timeline-start-bufferEvents.html
+++ b/LayoutTests/inspector-protocol/timeline/timeline-start-bufferEvents.html
@@ -11,6 +11,7 @@ function testFunction()
function test()
{
InspectorTest.eventHandler["Timeline.eventRecorded"] = eventRecorded;
+ InspectorTest.eventHandler["Timeline.stopped"] = timelineStopped;
InspectorTest.log("Recording started");
InspectorTest.sendCommand("Timeline.start", { bufferEvents: true }, onStart);
@@ -29,13 +30,19 @@ function test()
InspectorTest.log("FAIL: event recorded: " + event.params.record.type);
}
- function onStop(response)
+ function timelineStopped(event)
{
- InspectorTest.log("Recording stopped");
+ InspectorTest.log("Timeline.stopped event has arrived.");
+ InspectorTest.assert(!event.params.consoleTimeline, "It souldn't be event forced by console.timelineEnd");
InspectorTest.log("Events:");
- var events = response.result.events;
+ var events = event.params.events;
for (var i = 0; i < events.length; ++i)
dump(events[i], "");
+ }
+
+ function onStop(response)
+ {
+ InspectorTest.log("Recording stopped");
InspectorTest.completeTest();
}

Powered by Google App Engine
This is Rietveld 408576698