Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1636)

Unified Diff: Source/devtools/protocol.json

Issue 397813006: DevTools: move events array from Timeline.stop response to Timeline.stopped (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/protocol.json
diff --git a/Source/devtools/protocol.json b/Source/devtools/protocol.json
index a548f63d462d76661a9095bc4683baec583a9655..e67c71ae6951f1456746acb23dfa8187d58f9b80 100644
--- a/Source/devtools/protocol.json
+++ b/Source/devtools/protocol.json
@@ -2897,10 +2897,7 @@
},
{
"name": "stop",
- "description": "Stops capturing instrumentation events.",
- "returns": [
- { "name": "events", "type": "array", "items": { "$ref": "TimelineEvent" }, "optional": true, "hidden": true, "description": "Timeline event record data." }
- ]
+ "description": "Stops capturing instrumentation events."
}
],
"events": [
@@ -2929,7 +2926,8 @@
{
"name": "stopped",
"parameters": [
- { "name": "consoleTimeline", "type": "boolean", "optional": true, "description": "If specified, identifies that timeline was started using console.timeline() call." }
+ { "name": "consoleTimeline", "type": "boolean", "optional": true, "description": "If specified, identifies that timeline was started using console.timeline() call." },
+ { "name": "events", "type": "array", "items": { "$ref": "TimelineEvent" }, "optional": true, "hidden": true, "description": "Timeline event record data." }
alph 2014/07/18 10:47:44 We could consider making eventRecorded to allow pa
loislo 2014/07/18 11:42:24 I think it doesn't matter in general because we ar
],
"description": "Fired when timeline is stopped.",
"hidden": true

Powered by Google App Engine
This is Rietveld 408576698