Source/core/inspector/InspectorTimelineAgent.h - Issue 397813006: DevTools: move events array from Timeline.stop response to Timeline.stopped

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorTimelineAgent.h

Issue 397813006: DevTools: move events array from Timeline.stop response to Timeline.stopped (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector-protocol/timeline/timeline-start-bufferEvents-expected.txt ('k') | Source/core/inspector/InspectorTimelineAgent.cpp » ('j') | Source/devtools/front_end/sdk/TimelineManager.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorTimelineAgent.h

diff --git a/Source/core/inspector/InspectorTimelineAgent.h b/Source/core/inspector/InspectorTimelineAgent.h

index 68f863c15ed64a598e7be0e50fe6ecc19c49cd9e..cee00c0944cc45b71a3ff9eb488f2e146c6c3984 100644

--- a/Source/core/inspector/InspectorTimelineAgent.h

+++ b/Source/core/inspector/InspectorTimelineAgent.h

@@ -129,7 +129,7 @@ public:

virtual void enable(ErrorString*) OVERRIDE;

virtual void disable(ErrorString*) OVERRIDE;

virtual void start(ErrorString*, const int* maxCallStackDepth, const bool* bufferEvents, const String* liveEvents, const bool* includeCounters, const bool* includeGPUEvents) OVERRIDE;

- virtual void stop(ErrorString*, RefPtr<TypeBuilder::Array<TypeBuilder::Timeline::TimelineEvent> >& events) OVERRIDE;

+ virtual void stop(ErrorString*) OVERRIDE;

void setLayerTreeId(int layerTreeId) { m_layerTreeId = layerTreeId; }

int id() const { return m_id; }