Chromium Code Reviews| Index: Source/devtools/front_end/sdk/TimelineManager.js |
| diff --git a/Source/devtools/front_end/sdk/TimelineManager.js b/Source/devtools/front_end/sdk/TimelineManager.js |
| index 28d272e619001eaab24e7d667f62825822ac8263..8ebb9671a2eff30df8df5d0fa23a3317930bb398 100644 |
| --- a/Source/devtools/front_end/sdk/TimelineManager.js |
| +++ b/Source/devtools/front_end/sdk/TimelineManager.js |
| @@ -101,7 +101,7 @@ WebInspector.TimelineManager.prototype = { |
| this._jsProfilerStarted = false; |
| } |
| if (!this._enablementCount) |
| - TimelineAgent.stop(callbackBarrier.createCallback(this._processBufferedEvents.bind(this, timelineCallback))); |
| + TimelineAgent.stop(callbackBarrier.createCallback(timelineCallback)); |
| callbackBarrier.callWhenDone(allDoneCallback.bind(this)); |
| @@ -134,18 +134,14 @@ WebInspector.TimelineManager.prototype = { |
| }, |
| /** |
| - * @param {function(?Protocol.Error)|undefined} callback |
| - * @param {?Protocol.Error} error |
| * @param {!Array.<!TimelineAgent.TimelineEvent>=} events |
| */ |
| - _processBufferedEvents: function(callback, error, events) |
| + _processBufferedEvents: function(events) |
| { |
| if (events) { |
| for (var i = 0; i < events.length; ++i) |
| this._dispatcher.eventRecorded(events[i]); |
| } |
| - if (callback) |
| - callback(error); |
| }, |
| _configureCpuProfilerSamplingInterval: function() |
| @@ -208,11 +204,13 @@ WebInspector.TimelineDispatcher.prototype = { |
| /** |
| * @param {boolean=} consoleTimeline |
| + * @param {!Array.<!TimelineAgent.TimelineEvent>=} events |
| */ |
| - stopped: function(consoleTimeline) |
| + stopped: function(consoleTimeline, events) |
| { |
| this._started = false; |
| this._manager.dispatchEventToListeners(WebInspector.TimelineManager.EventTypes.TimelineStopped, consoleTimeline); |
| + this._manager._processBufferedEvents(events); |
|
alph
2014/07/18 10:47:43
Perhaps it's better to processBufferedEvents befor
loislo
2014/07/18 11:42:24
When we start the timeline we may specify a filter
|
| }, |
| /** |