Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 392013005: [#1] Delete reduntdant 19 header files in ui/gfx (8 of 19 by this) (Closed)

Created:
6 years, 5 months ago by hyunki
Modified:
6 years, 4 months ago
CC:
chromium-reviews, asanka, sadrul, nkostylev+watch_chromium.org, viettrungluu+watch_chromium.org, jdduke+watch_chromium.org, nasko+codewatch_chromium.org, dcheng, sievers+watch_chromium.org, yukishiino+watch_chromium.org, rsesek+watch_chromium.org, yusukes+watch_chromium.org, ben+aura_chromium.org, Ilya Sherman, ben+views_chromium.org, mkwst+watchlist_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, tdanderson+views_chromium.org, Aaron Boodman, benjhayden+dwatch_chromium.org, stevenjb+watch_chromium.org, jam, ben+mojo_chromium.org, abarth-chromium, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, ben+corewm_chromium.org, chromium-apps-reviews_chromium.org, Dane Wallinga, jennb, creis+watch_chromium.org, derat+watch_chromium.org, tdresser+watch_chromium.org, qsr+mojo_chromium.org, penghuang+watch_chromium.org, jianli, danakj+watch_chromium.org, yzshen+watch_chromium.org, oshima+watch_chromium.org, kalyank, piman+watch_chromium.org, gcasto+watchlist_chromium.org, darin (slow to review), rouslan+autofillwatch_chromium.org, chrome-apps-syd-reviews_chromium.org, Ian Vollick, tfarina, Dmitry Titov, benquan, ben+ash_chromium.org, dyu1, estade+watch_chromium.org, cc-bugs_chromium.org, James Su, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[#1] Delete reduntdant 19 header files in ui/gfx (8 of 19 by this) Deleted below reduntdant 19 header files in ui/gfx and changed ones in ui/gfx/geometry. For this patch, I'm deleting only 8 of 19 due to limitation of 2000 characters in 'cc'. This work should be done after merging the below blink-side patch. (https://codereview.chromium.org/400403002/) Other 11 files will be deleted by following patch. [Deleted by this] ui/gfx/box_f.h ui/gfx/point.h ui/gfx/point3_f.h ui/gfx/quad_f.h ui/gfx/insets.h ui/gfx/point_f.h ui/gfx/vector2d.h ui/gfx/matrix3_f.h [Will be deleted by next patch] ui/gfx/size.h ui/gfx/size_f.h ui/gfx/rect.h ui/gfx/rect_f.h ui/gfx/rect_conversions.h ui/gfx/size_conversions.h ui/gfx/point_conversions.h ui/gfx/vector2d_conversions.h ui/gfx/safe_interget_conversions.h ui/gfx/vector3d_f.h ui/gfx/vector2d_f.h BUG=395370

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : added ui/events/test/event_generator.h #

Patch Set 5 : added ui/compositor/dip_util.cc #

Total comments: 8

Patch Set 6 : sorted includes #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -397 lines) Patch
M apps/size_constraints.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M apps/ui/native_app_window.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/autoclick/autoclick_controller.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/dip_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_info.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/display/root_window_transformers.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 2 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/frame/caption_buttons/frame_size_button.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/magnification_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ash/magnifier/partial_magnification_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/popup_message.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/rotator/screen_rotation.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/overflow_bubble_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_tooltip_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/screen_security/screen_tray_item_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_popup_label_button_border.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/button_from_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/user_card_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_base.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/test/mirror_window_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/tooltips/tooltip_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_uma.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_native_cursor_manager.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/coordinate_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/drag_window_resizer.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/gestures/long_press_affordance_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/immersive_fullscreen_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_grid.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/partial_screenshot_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/two_step_edge_cycler.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/keyframed_animation_curve.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/keyframed_animation_curve_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/layer_animation_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/layer_animation_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/transform_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/transform_operations.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/transform_operations_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/base/float_quad_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/base/math_util.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M cc/base/math_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/base/tiling_data.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M cc/input/page_scale_animation.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/input/scrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_impl.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/layer_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_utils_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/tiled_layer_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/output/filter_operation.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/filter_operations_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/output/shader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/software_output_device.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/content_draw_quad_base.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/draw_quad.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/layer_quad.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/layer_quad.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/layer_quad_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/layer_updater.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/prioritized_resource.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/resource_provider.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/resource_update.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/texture_uploader.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_priority.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_sorter.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/occlusion_tracker.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/display/display_preferences.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/display/overscan_calibrator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_contents_resizing_strategy.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_embedder_message_dispatcher.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/drag_download_item_views.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_display/display_info_provider_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_icon_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/context_menu_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_positioner.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/popup_controller_common.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm View 1 2 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/ui/cocoa/confirm_bubble_controller.mm View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_stack_window_cocoa.mm View 1 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/ui/cocoa/panels/panel_utils_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/status_bubble_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/status_bubble_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_exit_bubble.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/detached_panel_collection.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/detached_panel_drag_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/docked_panel_drag_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_collection.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_drag_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_mouse_watcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_mouse_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_resize_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/stacked_panel_drag_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/test_panel_mouse_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/dock_info.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_linux_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_popup_view_views.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/generated_credit_card_bubble_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/info_bubble.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/info_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/new_credit_card_bubble_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_window_views_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_shelf_context_menu_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/message_center/message_center_widget_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/panels/x11_panel_resizer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/status_icons/status_icon_win.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/back_button.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_flash_menu_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_pdf_host.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/printing/print_web_view_helper_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/cloud_print/bitmap_image.h View 1 chunk +1 line, -1 line 0 comments Download
M components/web_modal/test_web_contents_modal_dialog_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/dip_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/text_input_client_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/text_input_client_message_filter.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_guest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/child/fling_animator_impl_android.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/fling_animator_impl_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_instance.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/common/browser_plugin/browser_plugin_messages.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/common/cursors/webcursor.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/common/drag_event_source_info.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/drag_messages.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/drag_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/synthetic_pinch_gesture_params.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/synthetic_smooth_scroll_gesture_params.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/input/synthetic_tap_gesture_params.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input_messages.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/common/page_state_serialization.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/view_messages.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/context_menu_params.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/compositor_bindings/web_layer_impl_fixed_bounds_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/external_popup_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/gfx_conversion.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/mock_renderer_ppapi_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_graphics_2d_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_graphics_2d_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/renderer_ppapi_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/text_input_client_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/sample_app/gles2_client_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/native_viewport/native_viewport_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/emf_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_metafile_skia.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_item_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/progress_bar_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/env.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/remote_window_tree_host_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_event_dispatcher.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_event_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_tree_host.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/aura/window_tree_host_mac.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_tree_host_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_tree_host_x11.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 1 comment Download
M ui/base/cursor/cursor_loader.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cursor/cursors_aura.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cursor/image_cursors.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/drag_utils_aura.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aura.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_win.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/base/test/ui_controls_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/touch/touch_editing_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/x/x11_util.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/base/x/x11_util.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositor.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/debug_utils.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/dip_util.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/dip_util.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/events/cocoa/events_mac.mm View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/cocoa/events_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/event.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/events/event.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/events/events_stub.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/gestures/gesture_point.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/test/event_generator.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/events/test/events_test_utils_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/win/events_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/events/x/device_data_manager_x11.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/events/x/events_x.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/events/x/events_x_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/blit.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/blit_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D ui/gfx/box_f.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/gfx/canvas_skia.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/color_analysis.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/display.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/display_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/icon_util.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_skia_operations.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
D ui/gfx/insets.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M ui/gfx/interpolated_transform.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
D ui/gfx/matrix3_f.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M ui/gfx/nine_image_painter.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
D ui/gfx/point.h View 1 chunk +0 lines, -7 lines 0 comments Download
D ui/gfx/point3_f.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
D ui/gfx/point_f.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
D ui/gfx/quad_f.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M ui/gfx/render_text.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/render_text.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/screen.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/shadow_value.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/shadow_value.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/shadow_value_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/skbitmap_operations.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/test/gfx_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/transform.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/transform_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ui/gfx/transform_util.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/transform_util_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
D ui/gfx/vector2d.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M ui/gfx/win/dpi.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/win/hwnd_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_center_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/toast_contents_view.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/views/border.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/bubble/bubble_frame_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/bubble/bubble_frame_view_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/bubble/tray_bubble_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/label_button_border.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/focusable_border.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/image_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/label.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_image_util.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar_views.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/slider.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/tooltip_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/tooltip_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/tooltip_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/layout/box_layout.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/layout/grid_layout.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/layout/grid_layout.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mouse_watcher.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/painter.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/rect_based_targeting_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/shadow_border.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_editing_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_editing_menu.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_window_move_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_topmost_window_finder.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/tooltip_manager_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/cursor_manager.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/user_activity_detector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/window_animations.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/window_animations_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/public/window_move_client.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
hyunki
This work should be done after merging the below blink-side patch. (https://codereview.chromium.org/400403002/)
6 years, 5 months ago (2014-07-19 14:58:57 UTC) #1
hyunki
On 2014/07/19 14:58:57, hyunki wrote: > This work should be done after merging the below ...
6 years, 5 months ago (2014-07-20 07:57:02 UTC) #2
hyunki
I think two more patches would be required to close this bug. (I mean totally ...
6 years, 5 months ago (2014-07-20 08:34:20 UTC) #3
sky
You seem to have a number of includes out of order. Didn't you get warnings ...
6 years, 5 months ago (2014-07-21 15:59:01 UTC) #4
hyunki
> You seem to have a number of includes out of order. Didn't you get ...
6 years, 5 months ago (2014-07-21 19:31:38 UTC) #5
hyunki
sky@, I've fixed all sort problem files using "presubmit_support.py". Please take a look. Thank you. ...
6 years, 5 months ago (2014-07-21 20:37:13 UTC) #6
hyunki
Ping. PTAL. Thank you!
6 years, 5 months ago (2014-07-23 23:03:58 UTC) #7
hyunki
6 years, 5 months ago (2014-07-24 09:08:45 UTC) #8
sky
This patch is too big and spans too many owners. You're going to have a ...
6 years, 5 months ago (2014-07-24 17:29:56 UTC) #9
sky
This patch is too big and spans too many owners. You're going to have a ...
6 years, 5 months ago (2014-07-24 17:30:01 UTC) #10
tfarina
https://codereview.chromium.org/392013005/diff/100001/ash/drag_drop/drag_drop_controller.cc File ash/drag_drop/drag_drop_controller.cc (right): https://codereview.chromium.org/392013005/diff/100001/ash/drag_drop/drag_drop_controller.cc#newcode28 ash/drag_drop/drag_drop_controller.cc:28: #include "ui/gfx/geometry/point.h" On 2014/07/24 17:29:56, sky wrote: > sort ...
6 years, 5 months ago (2014-07-24 17:33:16 UTC) #11
hyunki
sky@, tfarina@, Thanks for the comment and tip. I'll check and fix it up soon.
6 years, 5 months ago (2014-07-25 01:52:53 UTC) #12
hyunki
6 years, 5 months ago (2014-07-25 11:18:03 UTC) #13 
On 2014/07/24 17:30:01, sky wrote:
> This patch is too big and spans too many owners. You're going to have a really
> hard time landing it as is. Additionally you didn't update gyp/gn files yet. I
> recommend splitting into chunks that are reviewable by single owners. The
final
> step would be removing the files.

Yes. I see.
I'll close it and making splitted ones soon.

Powered by Google App Engine
This is Rietveld 408576698