Issue 386023004: Cleanup while reading code: Move GetJavaScriptMarker to be a free function instead of static functi…

Issue 386023004: Cleanup while reading code: Move GetJavaScriptMarker to be a free function instead of static functi… (Closed)

Created:
6 years, 5 months ago by chrishenry

Modified:
6 years, 5 months ago

Reviewers:
nednguyen

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Cleanup while reading code: Move GetJavaScriptMarker to be a free function instead of static function. Rename logical_name -> label (matching ActionRunner API). Improve documentation. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282807

Patch Set 1 : #

Patch Set 2 : Rebase and fix tests. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -51 lines)			Patch
M	tools/perf/measurements/smooth_gesture_util.py	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/perf/measurements/smoothness_controller.py	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/perf/measurements/timeline_controller.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/actions/action_runner.py	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	tools/telemetry/telemetry/page/actions/action_runner_unittest.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/web_perf/timeline_based_measurement.py	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	tools/telemetry/telemetry/web_perf/timeline_interaction_record.py	View	1	8 chunks	+32 lines, -20 lines	0 comments	Download
M	tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py	View	1	2 chunks	+11 lines, -12 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/386023004/40001

6 years, 5 months ago (2014-07-11 21:56:41 UTC) #3

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium ...

6 years, 5 months ago (2014-07-11 23:51:34 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/386023004/80001

6 years, 5 months ago (2014-07-12 00:12:57 UTC) #7

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...

6 years, 5 months ago (2014-07-12 04:10:47 UTC) #8

Message was sent while issue was closed.

Change committed as 282807

Expand Messages | Collapse Messages