tools/perf/measurements/smooth_gesture_util.py - Issue 386023004: Cleanup while reading code: Move GetJavaScriptMarker to be a free function instead of static functi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/smooth_gesture_util.py

Issue 386023004: Cleanup while reading code: Move GetJavaScriptMarker to be a free function instead of static functi… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix tests. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/smooth_gesture_util.py

diff --git a/tools/perf/measurements/smooth_gesture_util.py b/tools/perf/measurements/smooth_gesture_util.py

index 0930cc259156768b837eabda2b58861c5e190f70..a7d95d78b6347b660e012f554576130beccad29c 100644

--- a/tools/perf/measurements/smooth_gesture_util.py

+++ b/tools/perf/measurements/smooth_gesture_util.py

@@ -18,7 +18,7 @@ def GetAdjustedInteractionIfContainGesture(timeline, interaction_record):

markers.

"""

# Only adjust the range for gestures.

- if not interaction_record.logical_name.startswith('Gesture_'):

+ if not interaction_record.label.startswith('Gesture_'):

return copy.copy(interaction_record)

gesture_events = [

ev for ev

@@ -30,7 +30,7 @@ def GetAdjustedInteractionIfContainGesture(timeline, interaction_record):

return copy.copy(interaction_record)

if len(gesture_events) > 1:

raise Exception('More than one possible synthetic gesture marker found in '

- 'interaction_record %s.' % interaction_record.logical_name)

- return tir_module.TimelineInteractionRecord(interaction_record.logical_name,

+ 'interaction_record %s.' % interaction_record.label)

+ return tir_module.TimelineInteractionRecord(interaction_record.label,

gesture_events[0].start,

gesture_events[0].end)

« no previous file with comments | « no previous file | tools/perf/measurements/smoothness_controller.py » ('j') | no next file with comments »