tools/perf/measurements/timeline_controller.py - Issue 386023004: Cleanup while reading code: Move GetJavaScriptMarker to be a free function instead of static functi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/timeline_controller.py

Issue 386023004: Cleanup while reading code: Move GetJavaScriptMarker to be a free function instead of static functi… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix tests. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/timeline_controller.py

diff --git a/tools/perf/measurements/timeline_controller.py b/tools/perf/measurements/timeline_controller.py

index 42cbfd40cf508fa98d277a2840c1f76c8e715d31..77d39341e871ffcfb19080634eb1a2265a9c53eb 100644

--- a/tools/perf/measurements/timeline_controller.py

+++ b/tools/perf/measurements/timeline_controller.py

@@ -56,7 +56,7 @@ class TimelineController(object):

if not tir_module.IsTimelineInteractionRecord(event.name):

continue

r = tir_module.TimelineInteractionRecord.FromAsyncEvent(event)

- if r.logical_name == RUN_SMOOTH_ACTIONS:

+ if r.label == RUN_SMOOTH_ACTIONS:

assert run_smooth_actions_record is None, (

'TimelineController cannot issue more than 1 %s record' %

RUN_SMOOTH_ACTIONS)

« no previous file with comments | « tools/perf/measurements/smoothness_controller.py ('k') | tools/telemetry/telemetry/page/actions/action_runner.py » ('j') | no next file with comments »