Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

Issue 386023004: Cleanup while reading code: Move GetJavaScriptMarker to be a free function instead of static functi… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fix tests. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
index e7cd2b9da5dfdb4c118111fdf85a2505c1f34398..ca2cab04136d22f67b53bfd5af98cd594853387b 100644
--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
@@ -44,9 +44,9 @@ def _GetMetricFromMetricType(metric_type):
class _ResultsWrapper(object):
- def __init__(self, results, logical_name):
+ def __init__(self, results, label):
self._results = results
- self._result_prefix = logical_name
+ self._result_prefix = label
def _GetResultName(self, trace_name):
return '%s-%s' % (self._result_prefix, trace_name)
@@ -81,16 +81,16 @@ class _TimelineBasedMetrics(object):
raise InvalidInteractions('Expected at least one interaction record on '
'the page')
- interactions_by_logical_name = defaultdict(list)
+ interactions_by_label = defaultdict(list)
for i in all_interactions:
- interactions_by_logical_name[i.logical_name].append(i)
+ interactions_by_label[i.label].append(i)
- for logical_name, interactions in interactions_by_logical_name.iteritems():
+ for label, interactions in interactions_by_label.iteritems():
are_repeatable = [i.repeatable for i in interactions]
if not all(are_repeatable) and len(interactions) > 1:
raise InvalidInteractions('Duplicate unrepeatable interaction records '
'on the page')
- wrapped_results = _ResultsWrapper(results, logical_name)
+ wrapped_results = _ResultsWrapper(results, label)
self.UpdateResultsByMetric(interactions, wrapped_results)
def UpdateResultsByMetric(self, interactions, wrapped_results):

Powered by Google App Engine
This is Rietveld 408576698