tools/telemetry/telemetry/page/actions/action_runner_unittest.py - Issue 386023004: Cleanup while reading code: Move GetJavaScriptMarker to be a free function instead of static functi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/action_runner_unittest.py

Issue 386023004: Cleanup while reading code: Move GetJavaScriptMarker to be a free function instead of static functi… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix tests. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/actions/action_runner.py ('k') | tools/telemetry/telemetry/web_perf/timeline_based_measurement.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/actions/action_runner_unittest.py

diff --git a/tools/telemetry/telemetry/page/actions/action_runner_unittest.py b/tools/telemetry/telemetry/page/actions/action_runner_unittest.py

index 3ab9018a07f1f67390788777b9728bec637460a4..b15838ede69783759b7b4437282454a5019f8f45 100644

--- a/tools/telemetry/telemetry/page/actions/action_runner_unittest.py

+++ b/tools/telemetry/telemetry/page/actions/action_runner_unittest.py

@@ -34,7 +34,7 @@ class ActionRunnerTest(tab_test_case.TabTestCase):

self.assertEqual(1, len(records),

'Fail to issue the interaction record on tracing timeline.'

' Trace data:\n%s' % repr(trace_data.EventData()))

- self.assertEqual('TestInteraction', records[0].logical_name)

+ self.assertEqual('TestInteraction', records[0].label)

self.assertTrue(records[0].is_smooth)

def testExecuteJavaScript(self):