Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 379253003: Initial change to move 2D kernel to its own file (Closed)

Created:
6 years, 5 months ago by joshua.litt
Modified:
6 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Initial change to move 2D kernel to its own file. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ac9779234ef7a8cf3d791ab7690ef8c388662836

Patch Set 1 #

Patch Set 2 : small typos fixed #

Patch Set 3 : Small reorganization #

Patch Set 4 : Correctly wrapping asNewEffect definition with ifdefs #

Total comments: 1

Patch Set 5 : Feedback incorporated #

Patch Set 6 : rebase #

Patch Set 7 : fixed include #

Patch Set 8 : rebase #

Patch Set 9 : small cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+384 lines, -345 lines) Patch
M gyp/gpu.gypi View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M include/effects/SkMatrixConvolutionImageFilter.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 2 3 4 5 6 7 8 3 chunks +13 lines, -344 lines 0 comments Download
A src/gpu/effects/GrMatrixConvolutionEffect.h View 1 2 3 4 5 6 7 1 chunk +98 lines, -0 lines 0 comments Download
A src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 2 3 4 5 6 7 8 1 chunk +269 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
joshua.litt
I wasn't entirely sure what to do with SkMatrixConvolutionImageFilter's special tile modes. This is just ...
6 years, 5 months ago (2014-07-10 21:20:43 UTC) #1
bsalomon
https://codereview.chromium.org/379253003/diff/60001/src/gpu/effects/GrMatrixConvolutionEffect.h File src/gpu/effects/GrMatrixConvolutionEffect.h (right): https://codereview.chromium.org/379253003/diff/60001/src/gpu/effects/GrMatrixConvolutionEffect.h#newcode12 src/gpu/effects/GrMatrixConvolutionEffect.h:12: #include "../effects/SkMatrixConvolutionImageFilter.h" Hmm... we like the effects code to ...
6 years, 5 months ago (2014-07-11 13:07:41 UTC) #2
joshua.litt
On 2014/07/11 13:07:41, bsalomon wrote: > https://codereview.chromium.org/379253003/diff/60001/src/gpu/effects/GrMatrixConvolutionEffect.h > File src/gpu/effects/GrMatrixConvolutionEffect.h (right): > > https://codereview.chromium.org/379253003/diff/60001/src/gpu/effects/GrMatrixConvolutionEffect.h#newcode12 > ...
6 years, 5 months ago (2014-07-16 16:34:47 UTC) #3
bsalomon
lgtm
6 years, 5 months ago (2014-07-16 17:10:44 UTC) #4
joshua.litt
The CQ bit was checked by joshualitt@chromium.org
6 years, 5 months ago (2014-07-22 16:47:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/joshualitt@chromium.org/379253003/160001
6 years, 5 months ago (2014-07-22 16:47:33 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 16:52:17 UTC) #7
Message was sent while issue was closed.
Change committed as ac9779234ef7a8cf3d791ab7690ef8c388662836

Powered by Google App Engine
This is Rietveld 408576698