chrome/android/java/res/values-v17/styles.xml - Issue 377083002: Update menu look and feel on Android

Unified Diff: chrome/android/java/res/values-v17/styles.xml

Issue 377083002: Update menu look and feel on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/values-v17/styles.xml

diff --git a/chrome/android/java/res/values-v17/styles.xml b/chrome/android/java/res/values-v17/styles.xml

index 7ddbdf8e512e65e2854f933074939579b75e3fed..0f5e9e13ccdb3d9856d26c88d96353e2ec393dad 100644

--- a/chrome/android/java/res/values-v17/styles.xml

+++ b/chrome/android/java/res/values-v17/styles.xml

@@ -16,4 +16,14 @@

<item name="android:fontFamily">sans-serif</item>

</style>

+ <style name="OverflowMenuTheme" parent="Theme.AppCompat.Light">

+ <item name="android:popupBackground">@drawable/menu_bg</item>

aurimas (slooooooooow) 2014/07/08 23:49:44 Are we are setting the popupBackground twice: once

David Trainor- moved to gerrit 2014/07/09 00:01:56 Ah yeah I was going to make this null. Was still

+ <item name="android:dropDownWidth">460dp</item>

aurimas (slooooooooow) 2014/07/08 23:49:44 What happens for devices with screen width <460dp?

David Trainor- moved to gerrit 2014/07/09 00:01:56 Gah this needs to be removed. Nobody reads this p

+ <item name="android:listDivider">@null</item>

+ <item name="android:listPreferredItemHeightSmall">48dp</item>

+ <item name="android:listPreferredItemPaddingStart">16dp</item>

+ <item name="android:listPreferredItemPaddingEnd">16dp</item>

+ <item name="android:textSize">16sp</item>

+ <item name="android:fontFamily">Roboto</item>

aurimas (slooooooooow) 2014/07/08 23:49:44 s/Roboto/sans-serif We do not explicitly specify

David Trainor- moved to gerrit 2014/07/09 00:01:56 Ah yeah I'll use sans-serif. We do specify sans-s

+ </style>

</resources>