Update menu look and feel on Android

chrome/android/java/res/layout/three_button_menu_item.xml

Index: chrome/android/java/res/layout/three_button_menu_item.xml
diff --git a/chrome/android/java/res/layout/three_button_menu_item.xml b/chrome/android/java/res/layout/three_button_menu_item.xml
index 25f7074cc090698e27d055e3f53e6ed03a1f2aa6..0ed9a1605b0dd098ed1b6e3e439f66006c88aea4 100644
--- a/chrome/android/java/res/layout/three_button_menu_item.xml
+++ b/chrome/android/java/res/layout/three_button_menu_item.xml
@@ -10,38 +10,48 @@
     android:layout_gravity="top|start"
     android:orientation="horizontal">
 
+    <View
+        android:layout_width="0dp"
+        android:layout_height="?android:attr/listPreferredItemHeightSmall"
+        android:layout_weight="1"
+        android:background="@null" />
+
     <ImageButton
         android:id="@+id/button_one"
-        android:layout_width="wrap_content"
-        android:layout_height="match_parent"
-        android:layout_weight="1"
+        android:layout_width="48dp"

[aurimas (slooooooooow), 2014/07/08 23:49:44]

Same question as four_button_menu_item.

Why don't we use the full width for buttons instead of hardcoding them to 48dp?

[David Trainor- moved to gerrit, 2014/07/09 00:01:56]

Not hardcoding to 48dp also will make it difficult to line up the menu buttons
properly.  Also talked to Roma and this seemed like what they want.   Thinking
about it though, I'm not sure it'd be good to have shrunken hit targets.  Worst
case I can hard code the padding of the views to make it fit for 260dp...

+        android:layout_height="?android:attr/listPreferredItemHeightSmall"
         android:background="?android:attr/listChoiceBackgroundIndicator"
         android:scaleType="center" />
 
     <View
-        android:layout_width="1dp"
+        android:layout_width="0dp"
         android:layout_height="?android:attr/listPreferredItemHeightSmall"
-        android:background="?android:attr/listDivider" />
+        android:layout_weight="1"
+        android:background="@null" />
 
     <ImageButton
         android:id="@+id/button_two"
-        android:layout_width="wrap_content"
-        android:layout_height="match_parent"
-        android:layout_weight="1"
+        android:layout_width="48dp"
+        android:layout_height="?android:attr/listPreferredItemHeightSmall"
         android:background="?android:attr/listChoiceBackgroundIndicator"
         android:scaleType="center" />
 
     <View
-        android:layout_width="1dp"
+        android:layout_width="0dp"
         android:layout_height="?android:attr/listPreferredItemHeightSmall"
-        android:background="?android:attr/listDivider" />
+        android:layout_weight="1"
+        android:background="@null" />
 
     <ImageButton
         android:id="@+id/button_three"
-        android:layout_width="wrap_content"
-        android:layout_height="match_parent"
-        android:layout_weight="1"
+        android:layout_width="48dp"
+        android:layout_height="?android:attr/listPreferredItemHeightSmall"
         android:background="?android:attr/listChoiceBackgroundIndicator"
         android:scaleType="center" />
 
+    <View
+        android:layout_width="0dp"
+        android:layout_height="?android:attr/listPreferredItemHeightSmall"
+        android:layout_weight="1"
+        android:background="@null" />
 </LinearLayout>