Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7663)

Unified Diff: chrome/android/java/res/layout/title_button_menu_item.xml

Issue 377083002: Update menu look and feel on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/title_button_menu_item.xml
diff --git a/chrome/android/java/res/layout/title_button_menu_item.xml b/chrome/android/java/res/layout/title_button_menu_item.xml
index ee6aad0417daa2544cb814bd9d7d40708b71943b..20661a8906e0dd7ff32599fcb74ebedccf4ba8a6 100644
--- a/chrome/android/java/res/layout/title_button_menu_item.xml
+++ b/chrome/android/java/res/layout/title_button_menu_item.xml
@@ -6,7 +6,9 @@
-->
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
- android:layout_height="?android:attr/listPreferredItemHeightSmall">
+ android:layout_height="?android:attr/listPreferredItemHeightSmall"
+ android:paddingStart="?android:attr/listPreferredItemPaddingStart"
+ android:paddingEnd="?android:attr/listPreferredItemPaddingEnd">
<TextView
android:id="@+id/title"
@@ -17,22 +19,17 @@
android:background="?android:attr/listChoiceBackgroundIndicator"
android:gravity="center_vertical"
android:paddingEnd="9dp"
- android:paddingStart="9dp"
android:singleLine="true"
android:textAppearance="?android:attr/textAppearanceLargePopupMenu" />
- <View
- android:id="@+id/divider"
- android:layout_width="1dp"
- android:layout_height="match_parent"
- android:background="?android:attr/listDivider" />
-
<ImageButton
android:id="@+id/button"
android:layout_width="48dp"
android:layout_height="48dp"
android:background="?android:attr/listChoiceBackgroundIndicator"
- android:padding="10dp"
+ android:paddingStart="10dp"
+ android:paddingTop="10dp"
+ android:paddingBottom="10dp"
android:scaleType="fitCenter" />
</LinearLayout>

Powered by Google App Engine
This is Rietveld 408576698