Chromium Code Reviews| Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java |
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java |
| index 4cfefcf0d77a9275482fcbe68c7299777ee2ef09..a227ef07873ad69287375c247956d6ec7c9d0600 100644 |
| --- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java |
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java |
| @@ -65,7 +65,7 @@ public class AppMenu implements OnItemClickListener, OnKeyListener { |
| mHandler = handler; |
| mItemDividerHeight = itemDividerHeight; |
| - assert mItemDividerHeight > 0; |
| + assert mItemDividerHeight >= 0; |
| mAdditionalVerticalOffset = res.getDimensionPixelSize(R.dimen.menu_vertical_offset); |
| mVerticalFadeDistance = res.getDimensionPixelSize(R.dimen.menu_vertical_fade_distance); |
| @@ -99,6 +99,10 @@ public class AppMenu implements OnItemClickListener, OnKeyListener { |
| }); |
| mPopup.setWidth(context.getResources().getDimensionPixelSize(R.dimen.menu_width)); |
| + // Need to explicitly set the background here. Relying on it being set in the style caused |
| + // an incorrectly drawn background. |
|
aurimas (slooooooooow)
2014/07/08 23:49:44
Can you file a bug about this to Android?
David Trainor- moved to gerrit
2014/07/09 00:01:56
Will write up a small test app and confirm it and
|
| + mPopup.setBackgroundDrawable(context.getResources().getDrawable(R.drawable.menu_bg)); |
| + |
| mCurrentScreenRotation = screenRotation; |
| mIsByHardwareButton = isByHardwareButton; |