chrome/android/java/res/values-v17/styles.xml - Issue 377083002: Update menu look and feel on Android

Side by Side Diff: chrome/android/java/res/values-v17/styles.xml

Issue 377083002: Update menu look and feel on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/three_button_menu_item.xml ('K') | « chrome/android/java/res/layout/title_button_menu_item.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file.

5 -->	5 -->

6	6

7 <resources>	7 <resources>

8 <style name="AppBannerTitle">	8 <style name="AppBannerTitle">

9 <item name="android:textColor">#333333</item>	9 <item name="android:textColor">#333333</item>

10 <item name="android:textSize">@dimen/app_banner_title_text_size</item>	10 <item name="android:textSize">@dimen/app_banner_title_text_size</item>

11 <item name="android:fontFamily">sans-serif-light</item>	11 <item name="android:fontFamily">sans-serif-light</item>

12 </style>	12 </style>

13 <style name="AppBannerButton">	13 <style name="AppBannerButton">

14 <item name="android:textSize">@dimen/app_banner_button_text_size</item>	14 <item name="android:textSize">@dimen/app_banner_button_text_size</item>

15 <item name="android:textAllCaps">true</item>	15 <item name="android:textAllCaps">true</item>

16 <item name="android:fontFamily">sans-serif</item>	16 <item name="android:fontFamily">sans-serif</item>

17 <item name="android:textStyle">bold</item>	17 <item name="android:textStyle">bold</item>

18 </style>	18 </style>

	19 <style name="OverflowMenuTheme" parent="Theme.AppCompat.Light">

	20 <item name="android:popupBackground">@drawable/menu_bg</item>
	aurimas (slooooooooow) 2014/07/08 23:49:44 Are we are setting the popupBackground twice: once Are we are setting the popupBackground twice: once from Java and once here? Should we set the background here to be @null then? David Trainor- moved to gerrit 2014/07/09 00:01:56 Ah yeah I was going to make this null. Was still Show quoted text On 2014/07/08 23:49:44, aurimas wrote: > Are we are setting the popupBackground twice: once from Java and once here? > Should we set the background here to be @null then? Ah yeah I was going to make this null. Was still playing with it a bit to see if I could fix it. My bad forgot to move it over.
	21 <item name="android:dropDownWidth">460dp</item>
	aurimas (slooooooooow) 2014/07/08 23:49:44 What happens for devices with screen width <460dp? What happens for devices with screen width <460dp? Galaxy start for example is 320dp. The mock seems to say 260dp? How is this different from menu_width in dimens.xml? David Trainor- moved to gerrit 2014/07/09 00:01:56 Gah this needs to be removed. Nobody reads this p Show quoted text On 2014/07/08 23:49:44, aurimas wrote: > What happens for devices with screen width <460dp? Galaxy start for example is > 320dp. > > The mock seems to say 260dp? > > How is this different from menu_width in dimens.xml? Gah this needs to be removed. Nobody reads this parameter (even in ListPopupWindow).
	22 <item name="android:listDivider">@null</item>

	23 <item name="android:listPreferredItemHeightSmall">48dp</item>

	24 <item name="android:listPreferredItemPaddingStart">16dp</item>

	25 <item name="android:listPreferredItemPaddingEnd">16dp</item>

	26 <item name="android:textSize">16sp</item>

	27 <item name="android:fontFamily">Roboto</item>
	aurimas (slooooooooow) 2014/07/08 23:49:44 s/Roboto/sans-serif We do not explicitly specify s/Roboto/sans-serif We do not explicitly specify the font family anywhere else in Chrome for Android. David Trainor- moved to gerrit 2014/07/09 00:01:56 Ah yeah I'll use sans-serif. We do specify sans-s Show quoted text On 2014/07/08 23:49:44, aurimas wrote: > s/Roboto/sans-serif > > We do not explicitly specify the font family anywhere else in Chrome for > Android. Ah yeah I'll use sans-serif. We do specify sans-serif throughout the code, but not Roboto.
	28 </style>

19 </resources>	29 </resources>

OLD	NEW