Fixes for re-enabling more MSVC level 4 warnings: gpu/ edition

Fixes for re-enabling more MSVC level 4 warnings: gpu/ edition

This contains fixes for the following sorts of issues:
* Signedness mismatch
* Possibly-uninitialized local variable

BUG=81439
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281900

[no sievers, 2014-07-08 00:51:13]

lgtm

https://codereview.chromium.org/375733004/diff/1/gpu/command_buffer/client/tr...
File gpu/command_buffer/client/transfer_buffer_unittest.cc (right):

https://codereview.chromium.org/375733004/diff/1/gpu/command_buffer/client/tr...
gpu/command_buffer/client/transfer_buffer_unittest.cc:188:
transfer_buffer_->FreePendingToken(ptr, static_cast<unsigned int>(-1));
nit: can you do '-1u' instead of the cast?

https://codereview.chromium.org/375733004/diff/1/gpu/command_buffer/common/id...
File gpu/command_buffer/common/id_allocator_test.cc (right):

https://codereview.chromium.org/375733004/diff/1/gpu/command_buffer/common/id...
gpu/command_buffer/common/id_allocator_test.cc:103: const ResourceId
kMaxPossibleOffset = ~static_cast<ResourceId>(0);
same

https://codereview.chromium.org/375733004/diff/1/gpu/command_buffer/service/g...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc (right):

https://codereview.chromium.org/375733004/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc:468:
static_cast<GLuint>(-1),
-1u?

https://codereview.chromium.org/375733004/diff/1/gpu/command_buffer/service/g...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc (right):

https://codereview.chromium.org/375733004/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc:106:
cached_stencil_front_mask_(static_cast<GLuint>(-1)),
-1u?

[Peter Kasting, 2014-07-08 01:03:51]

https://codereview.chromium.org/375733004/diff/1/gpu/command_buffer/client/tr...
File gpu/command_buffer/client/transfer_buffer_unittest.cc (right):

https://codereview.chromium.org/375733004/diff/1/gpu/command_buffer/client/tr...
gpu/command_buffer/client/transfer_buffer_unittest.cc:188:
transfer_buffer_->FreePendingToken(ptr, static_cast<unsigned int>(-1));
On 2014/07/08 00:51:13, sievers wrote:
> nit: can you do '-1u' instead of the cast?

Nope.  That produces this warning instead:

warning C4146: unary minus operator applied to unsigned type, result still
unsigned

(Same answer applies to your other comments)

[Peter Kasting, 2014-07-08 01:04:11]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2014-07-08 01:06:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkasting@chromium.org/375733004/1

[commit-bot: I haz the power, 2014-07-08 02:53:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/25682)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/30136)

[commit-bot: I haz the power, 2014-07-08 02:58:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-08 02:58:07]

Try jobs failed on following builders:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)

[Peter Kasting, 2014-07-08 18:49:26]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2014-07-08 18:50:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkasting@chromium.org/375733004/20001

[commit-bot: I haz the power, 2014-07-08 19:57:15]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/26038)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/30483)

[Peter Kasting, 2014-07-08 20:04:07]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2014-07-08 20:05:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkasting@chromium.org/375733004/40001

[commit-bot: I haz the power, 2014-07-09 00:22:52]

Change committed as 281900