Fixes for re-enabling more MSVC level 4 warnings: gpu/ edition

gpu/command_buffer/client/transfer_buffer_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Tests for the Command Buffer Helper.
 
 #include "gpu/command_buffer/client/transfer_buffer.h"
 
 #include "base/compiler_specific.h"
 #include "gpu/command_buffer/client/client_test_helper.h"
@@ skipping 167 matching lines @@
       kTransferBufferSize + 1, &size_allocated);
   ASSERT_TRUE(ptr != NULL);
   EXPECT_EQ(kTransferBufferSize - kStartingOffset, size_allocated);
   transfer_buffer_->FreePendingToken(ptr, 1);
 }
 
 TEST_F(TransferBufferTest, MemoryAlignmentAfterZeroAllocation) {
   Initialize(32u);
   void* ptr = transfer_buffer_->Alloc(0);
   EXPECT_EQ((reinterpret_cast<uintptr_t>(ptr) & (kAlignment - 1)), 0u);
-  transfer_buffer_->FreePendingToken(ptr, -1);
+  transfer_buffer_->FreePendingToken(ptr, static_cast<unsigned int>(-1));

[no sievers, 2014/07/08 00:51:13]

nit: can you do '-1u' instead of the cast?

[Peter Kasting, 2014/07/08 01:03:51]

Nope.  That produces this warning instead:

warning C4146: unary minus operator applied to unsigned type, result still
unsigned

(Same answer applies to your other comments)

   // Check that the pointer is aligned on the following allocation.
   ptr = transfer_buffer_->Alloc(4);
   EXPECT_EQ((reinterpret_cast<uintptr_t>(ptr) & (kAlignment - 1)), 0u);
   transfer_buffer_->FreePendingToken(ptr, 1);
 }
 
 TEST_F(TransferBufferTest, Flush) {
   Initialize(16u);
   unsigned int size_allocated = 0;
   for (int i = 0; i < 8; ++i) {
@@ skipping 277 matching lines @@
 
   // Check it's the default size.
   EXPECT_EQ(
       kStartTransferBufferSize - kStartingOffset,
       transfer_buffer_->GetCurrentMaxAllocationWithoutRealloc());
 }
 
 }  // namespace gpu