Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 373833002: Fix gpu_unittests for new Shader Translator header. (Closed)

Created:
6 years, 5 months ago by Jamie Madill
Modified:
6 years, 5 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix gpu_unittests for new Shader Translator header. BUG=389276 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281743

Patch Set 1 #

Patch Set 2 : Fix macro for Windows compiler #

Patch Set 3 : Fix more Windows define-in-macro #

Patch Set 4 : Remove temporary DEPS change #

Patch Set 5 : No change #

Total comments: 2

Patch Set 6 : Added TODO comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M gpu/command_buffer/service/mocks.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/shader_translator_unittest.cc View 1 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Jamie Madill
PTAL
6 years, 5 months ago (2014-07-07 20:28:44 UTC) #1
Zhenyao Mo
LGTM https://codereview.chromium.org/373833002/diff/80001/gpu/command_buffer/service/program_manager_unittest.cc File gpu/command_buffer/service/program_manager_unittest.cc (right): https://codereview.chromium.org/373833002/diff/80001/gpu/command_buffer/service/program_manager_unittest.cc#newcode34 gpu/command_buffer/service/program_manager_unittest.cc:34: // ANGLE now uses GLenum values directory for ...
6 years, 5 months ago (2014-07-07 20:35:13 UTC) #2
Jamie Madill
The CQ bit was checked by jmadill@chromium.org
6 years, 5 months ago (2014-07-07 20:50:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jmadill@chromium.org/373833002/100001
6 years, 5 months ago (2014-07-07 20:51:09 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 00:45:44 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 01:26:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/90406)
6 years, 5 months ago (2014-07-08 01:26:20 UTC) #7
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 5 months ago (2014-07-08 01:37:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jmadill@chromium.org/373833002/100001
6 years, 5 months ago (2014-07-08 01:38:33 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 02:15:07 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 02:38:51 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/90475)
6 years, 5 months ago (2014-07-08 02:38:52 UTC) #12
Jamie Madill
The CQ bit was checked by jmadill@chromium.org
6 years, 5 months ago (2014-07-08 13:20:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jmadill@chromium.org/373833002/100001
6 years, 5 months ago (2014-07-08 13:21:20 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 14:05:21 UTC) #15
Message was sent while issue was closed. 
Change committed as 281743

Powered by Google App Engine
This is Rietveld 408576698