Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 371973002: Fix computed properties on object literals with a double as propertyname. (Closed)

Created:
6 years, 5 months ago by Toon Verwaest
Modified:
6 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix computed properties on object literals with a double as propertyname. BUG=390732 LOG=y R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 3 chunks +12 lines, -15 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-double-property.js View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 5 months ago (2014-07-07 16:54:18 UTC) #1
Igor Sheludko
lgtm
6 years, 5 months ago (2014-07-07 17:07:39 UTC) #2
Toon Verwaest
6 years, 5 months ago (2014-07-07 17:09:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22255 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698