Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 371973002: Fix computed properties on object literals with a double as propertyname. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/runtime.cc ('k') | test/mjsunit/regress/regress-double-property.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1661 matching lines...) Expand 10 before | Expand all | Expand 10 after
1672 PrepareForBailoutForId(key->id(), NO_REGISTERS); 1672 PrepareForBailoutForId(key->id(), NO_REGISTERS);
1673 } else { 1673 } else {
1674 VisitForEffect(value); 1674 VisitForEffect(value);
1675 } 1675 }
1676 break; 1676 break;
1677 } 1677 }
1678 __ Push(Operand(rsp, 0)); // Duplicate receiver. 1678 __ Push(Operand(rsp, 0)); // Duplicate receiver.
1679 VisitForStackValue(key); 1679 VisitForStackValue(key);
1680 VisitForStackValue(value); 1680 VisitForStackValue(value);
1681 if (property->emit_store()) { 1681 if (property->emit_store()) {
1682 __ Push(Smi::FromInt(NONE)); // PropertyAttributes 1682 __ Push(Smi::FromInt(SLOPPY)); // Strict mode
1683 __ CallRuntime(Runtime::kAddProperty, 4); 1683 __ CallRuntime(Runtime::kSetProperty, 4);
1684 } else { 1684 } else {
1685 __ Drop(3); 1685 __ Drop(3);
1686 } 1686 }
1687 break; 1687 break;
1688 case ObjectLiteral::Property::PROTOTYPE: 1688 case ObjectLiteral::Property::PROTOTYPE:
1689 __ Push(Operand(rsp, 0)); // Duplicate receiver. 1689 __ Push(Operand(rsp, 0)); // Duplicate receiver.
1690 VisitForStackValue(value); 1690 VisitForStackValue(value);
1691 if (property->emit_store()) { 1691 if (property->emit_store()) {
1692 __ CallRuntime(Runtime::kSetPrototype, 2); 1692 __ CallRuntime(Runtime::kSetPrototype, 2);
1693 } else { 1693 } else {
(...skipping 3118 matching lines...) Expand 10 before | Expand all | Expand 10 after
4812 ASSERT_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 4812 ASSERT_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
4813 Assembler::target_address_at(call_target_address, 4813 Assembler::target_address_at(call_target_address,
4814 unoptimized_code)); 4814 unoptimized_code));
4815 return OSR_AFTER_STACK_CHECK; 4815 return OSR_AFTER_STACK_CHECK;
4816 } 4816 }
4817 4817
4818 4818
4819 } } // namespace v8::internal 4819 } } // namespace v8::internal
4820 4820
4821 #endif // V8_TARGET_ARCH_X64 4821 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/runtime.cc ('k') | test/mjsunit/regress/regress-double-property.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698