Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: src/arm64/full-codegen-arm64.cc

Issue 371973002: Fix computed properties on object literals with a double as propertyname. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1679 matching lines...) Expand 10 before | Expand all | Expand 10 after
1690 VisitForEffect(value); 1690 VisitForEffect(value);
1691 } 1691 }
1692 break; 1692 break;
1693 } 1693 }
1694 if (property->emit_store()) { 1694 if (property->emit_store()) {
1695 // Duplicate receiver on stack. 1695 // Duplicate receiver on stack.
1696 __ Peek(x0, 0); 1696 __ Peek(x0, 0);
1697 __ Push(x0); 1697 __ Push(x0);
1698 VisitForStackValue(key); 1698 VisitForStackValue(key);
1699 VisitForStackValue(value); 1699 VisitForStackValue(value);
1700 __ Mov(x0, Smi::FromInt(NONE)); // PropertyAttributes 1700 __ Mov(x0, Smi::FromInt(SLOPPY)); // Strict mode
1701 __ Push(x0); 1701 __ Push(x0);
1702 __ CallRuntime(Runtime::kAddProperty, 4); 1702 __ CallRuntime(Runtime::kSetProperty, 4);
1703 } else { 1703 } else {
1704 VisitForEffect(key); 1704 VisitForEffect(key);
1705 VisitForEffect(value); 1705 VisitForEffect(value);
1706 } 1706 }
1707 break; 1707 break;
1708 case ObjectLiteral::Property::PROTOTYPE: 1708 case ObjectLiteral::Property::PROTOTYPE:
1709 if (property->emit_store()) { 1709 if (property->emit_store()) {
1710 // Duplicate receiver on stack. 1710 // Duplicate receiver on stack.
1711 __ Peek(x0, 0); 1711 __ Peek(x0, 0);
1712 __ Push(x0); 1712 __ Push(x0);
(...skipping 3176 matching lines...) Expand 10 before | Expand all | Expand 10 after
4889 return previous_; 4889 return previous_;
4890 } 4890 }
4891 4891
4892 4892
4893 #undef __ 4893 #undef __
4894 4894
4895 4895
4896 } } // namespace v8::internal 4896 } } // namespace v8::internal
4897 4897
4898 #endif // V8_TARGET_ARCH_ARM64 4898 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698