Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 371973002: Fix computed properties on object literals with a double as propertyname. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1690 matching lines...) Expand 10 before | Expand all | Expand 10 after
1701 VisitForEffect(value); 1701 VisitForEffect(value);
1702 } 1702 }
1703 break; 1703 break;
1704 } 1704 }
1705 // Duplicate receiver on stack. 1705 // Duplicate receiver on stack.
1706 __ ldr(r0, MemOperand(sp)); 1706 __ ldr(r0, MemOperand(sp));
1707 __ push(r0); 1707 __ push(r0);
1708 VisitForStackValue(key); 1708 VisitForStackValue(key);
1709 VisitForStackValue(value); 1709 VisitForStackValue(value);
1710 if (property->emit_store()) { 1710 if (property->emit_store()) {
1711 __ mov(r0, Operand(Smi::FromInt(NONE))); // PropertyAttributes 1711 __ mov(r0, Operand(Smi::FromInt(SLOPPY))); // PropertyAttributes
1712 __ push(r0); 1712 __ push(r0);
1713 __ CallRuntime(Runtime::kAddProperty, 4); 1713 __ CallRuntime(Runtime::kSetProperty, 4);
1714 } else { 1714 } else {
1715 __ Drop(3); 1715 __ Drop(3);
1716 } 1716 }
1717 break; 1717 break;
1718 case ObjectLiteral::Property::PROTOTYPE: 1718 case ObjectLiteral::Property::PROTOTYPE:
1719 // Duplicate receiver on stack. 1719 // Duplicate receiver on stack.
1720 __ ldr(r0, MemOperand(sp)); 1720 __ ldr(r0, MemOperand(sp));
1721 __ push(r0); 1721 __ push(r0);
1722 VisitForStackValue(value); 1722 VisitForStackValue(value);
1723 if (property->emit_store()) { 1723 if (property->emit_store()) {
(...skipping 3135 matching lines...) Expand 10 before | Expand all | Expand 10 after
4859 4859
4860 ASSERT(interrupt_address == 4860 ASSERT(interrupt_address ==
4861 isolate->builtins()->OsrAfterStackCheck()->entry()); 4861 isolate->builtins()->OsrAfterStackCheck()->entry());
4862 return OSR_AFTER_STACK_CHECK; 4862 return OSR_AFTER_STACK_CHECK;
4863 } 4863 }
4864 4864
4865 4865
4866 } } // namespace v8::internal 4866 } } // namespace v8::internal
4867 4867
4868 #endif // V8_TARGET_ARCH_ARM 4868 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698