Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 371973002: Fix computed properties on object literals with a double as propertyname. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm64/full-codegen-arm64.cc ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1628 matching lines...) Expand 10 before | Expand all | Expand 10 after
1639 PrepareForBailoutForId(key->id(), NO_REGISTERS); 1639 PrepareForBailoutForId(key->id(), NO_REGISTERS);
1640 } else { 1640 } else {
1641 VisitForEffect(value); 1641 VisitForEffect(value);
1642 } 1642 }
1643 break; 1643 break;
1644 } 1644 }
1645 __ push(Operand(esp, 0)); // Duplicate receiver. 1645 __ push(Operand(esp, 0)); // Duplicate receiver.
1646 VisitForStackValue(key); 1646 VisitForStackValue(key);
1647 VisitForStackValue(value); 1647 VisitForStackValue(value);
1648 if (property->emit_store()) { 1648 if (property->emit_store()) {
1649 __ push(Immediate(Smi::FromInt(NONE))); // PropertyAttributes 1649 __ push(Immediate(Smi::FromInt(SLOPPY))); // Strict mode
1650 __ CallRuntime(Runtime::kAddProperty, 4); 1650 __ CallRuntime(Runtime::kSetProperty, 4);
1651 } else { 1651 } else {
1652 __ Drop(3); 1652 __ Drop(3);
1653 } 1653 }
1654 break; 1654 break;
1655 case ObjectLiteral::Property::PROTOTYPE: 1655 case ObjectLiteral::Property::PROTOTYPE:
1656 __ push(Operand(esp, 0)); // Duplicate receiver. 1656 __ push(Operand(esp, 0)); // Duplicate receiver.
1657 VisitForStackValue(value); 1657 VisitForStackValue(value);
1658 if (property->emit_store()) { 1658 if (property->emit_store()) {
1659 __ CallRuntime(Runtime::kSetPrototype, 2); 1659 __ CallRuntime(Runtime::kSetPrototype, 2);
1660 } else { 1660 } else {
(...skipping 3141 matching lines...) Expand 10 before | Expand all | Expand 10 after
4802 ASSERT_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 4802 ASSERT_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
4803 Assembler::target_address_at(call_target_address, 4803 Assembler::target_address_at(call_target_address,
4804 unoptimized_code)); 4804 unoptimized_code));
4805 return OSR_AFTER_STACK_CHECK; 4805 return OSR_AFTER_STACK_CHECK;
4806 } 4806 }
4807 4807
4808 4808
4809 } } // namespace v8::internal 4809 } } // namespace v8::internal
4810 4810
4811 #endif // V8_TARGET_ARCH_IA32 4811 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm64/full-codegen-arm64.cc ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698