|
Add always-threaded SkRecord quilt tests.
Now that we're drawing tiles threaded like implside painting, remove the checks
that those lock counts are balanced. They're just not right for anyone anymore.
SkBitmaps themselves are not threadsafe (even const ones), so shallow copy them
on playback of an SkRecord. (The underlying SkPixelRefs are threadsafe.)
Simplify quilt drawing by using SkBitmap::extractSubset. No need for locking.
Bump up to 256x256 tiles. 16x16 tiles just murders performance (way too much
contention). This has the nice side effect of letting us enable a bunch more
GMs for quilt mode; they drew wrong with small tiles but exactly right with large.
BUG= 171776
Committed: https://skia.googlesource.com/skia/+/7cdc1ee11545a10708e857adf1d4a94a2f1e2a48
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+47 lines, -208 lines) |
Patch |
|
M |
dm/DMCpuGMTask.cpp
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
dm/DMQuiltTask.h
|
View
|
|
1 chunk |
+10 lines, -3 lines |
0 comments
|
Download
|
|
M |
dm/DMQuiltTask.cpp
|
View
|
1
2
3
|
2 chunks |
+21 lines, -29 lines |
0 comments
|
Download
|
|
M |
gm/bigmatrix.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/bitmaprecttest.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/bitmapscroll.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/bitmapshader.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/blurrect.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
gm/blurroundrect.cpp
|
View
|
1
2
3
4
5
|
2 chunks |
+0 lines, -8 lines |
0 comments
|
Download
|
|
M |
gm/coloremoji.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/composeshader.cpp
|
View
|
1
2
3
4
5
|
2 chunks |
+0 lines, -9 lines |
0 comments
|
Download
|
|
M |
gm/drawlooper.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/filterindiabox.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/gradientDirtyLaundry.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/gradients.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/gradients_2pt_conical.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
|
M |
gm/gradtext.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
|
M |
gm/lerpmode.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/ninepatchstretch.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/pathinterior.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/pathopsinverse.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/pathopsskpclip.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/resizeimagefilter.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/samplerstress.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/shadows.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/simpleaaclip.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/skbug1719.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/thinstrokedrects.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/tilemodes_scaled.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
|
M |
gm/twopointradial.cpp
|
View
|
1
2
3
4
5
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gm/verylargebitmap.cpp
|
View
|
1
2
3
4
5
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
src/core/SkCanvas.cpp
|
View
|
|
4 chunks |
+0 lines, -45 lines |
0 comments
|
Download
|
|
M |
src/core/SkRecordDraw.cpp
|
View
|
|
3 chunks |
+11 lines, -5 lines |
0 comments
|
Download
|
Total messages: 5 (0 generated)
|