Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Issue 362273002: DevTools: Reduce code via using document.createElementWithClass and document.createChild. (Closed)

Created:
6 years, 5 months ago by aandrey
Modified:
6 years, 5 months ago
Reviewers:
apavlov, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Reduce code via using document.createElementWithClass and document.createChild. R=vsevik, apavlov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177390

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -136 lines) Patch
M Source/devtools/front_end/common/DOMExtension.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/resources/ResourcesPanel.js View 4 chunks +17 lines, -34 lines 0 comments Download
M Source/devtools/front_end/source_frame/ImageView.js View 2 chunks +9 lines, -31 lines 0 comments Download
M Source/devtools/front_end/source_frame/SourceFrame.js View 2 chunks +3 lines, -7 lines 0 comments Download
M Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 chunk +4 lines, -9 lines 0 comments Download
M Source/devtools/front_end/sources/NavigatorView.js View 2 chunks +11 lines, -22 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesView.js View 2 chunks +2 lines, -8 lines 0 comments Download
M Source/devtools/front_end/ui/Checkbox.js View 1 chunk +3 lines, -6 lines 0 comments Download
M Source/devtools/front_end/ui/Popover.js View 1 chunk +2 lines, -7 lines 0 comments Download
M Source/devtools/front_end/ui/SidebarPane.js View 1 chunk +1 line, -5 lines 0 comments Download
M Source/devtools/front_end/ui/View.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
aandrey
6 years, 5 months ago (2014-07-02 09:56:44 UTC) #1
vsevik
lgtm
6 years, 5 months ago (2014-07-02 12:18:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/362273002/1
6 years, 5 months ago (2014-07-02 12:19:04 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-02 13:25:03 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 14:28:49 UTC) #5
Message was sent while issue was closed.
Change committed as 177390

Powered by Google App Engine
This is Rietveld 408576698