Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1512)

Unified Diff: Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 362273002: DevTools: Reduce code via using document.createElementWithClass and document.createChild. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sources/JavaScriptSourceFrame.js
diff --git a/Source/devtools/front_end/sources/JavaScriptSourceFrame.js b/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
index 5bf05626c433cbfe7aed0566ff1231b2fda2f5b5..124c1323f33c22661ef1ff2ae2c3fe3fa7099f0b 100644
--- a/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
+++ b/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
@@ -646,20 +646,15 @@ WebInspector.JavaScriptSourceFrame.prototype = {
_createConditionElement: function(lineNumber)
{
- var conditionElement = document.createElement("div");
- conditionElement.className = "source-frame-breakpoint-condition";
+ var conditionElement = document.createElementWithClass("div", "source-frame-breakpoint-condition");
- var labelElement = document.createElement("label");
- labelElement.className = "source-frame-breakpoint-message";
+ var labelElement = conditionElement.createChild("label", "source-frame-breakpoint-message");
labelElement.htmlFor = "source-frame-breakpoint-condition";
- labelElement.appendChild(document.createTextNode(WebInspector.UIString("The breakpoint on line %d will stop only if this expression is true:", lineNumber + 1)));
- conditionElement.appendChild(labelElement);
+ labelElement.createTextChild(WebInspector.UIString("The breakpoint on line %d will stop only if this expression is true:", lineNumber + 1));
- var editorElement = document.createElement("input");
+ var editorElement = conditionElement.createChild("input", "monospace");
editorElement.id = "source-frame-breakpoint-condition";
- editorElement.className = "monospace";
editorElement.type = "text";
- conditionElement.appendChild(editorElement);
this._conditionEditorElement = editorElement;
return conditionElement;
« no previous file with comments | « Source/devtools/front_end/source_frame/SourceFrame.js ('k') | Source/devtools/front_end/sources/NavigatorView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698