Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: Source/devtools/front_end/ui/Popover.js

Issue 362273002: DevTools: Reduce code via using document.createElementWithClass and document.createChild. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/ui/Checkbox.js ('k') | Source/devtools/front_end/ui/SidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ui/Popover.js
diff --git a/Source/devtools/front_end/ui/Popover.js b/Source/devtools/front_end/ui/Popover.js
index e0a28e1691e05fd017f1cacd10c982451df40d37..d796ed7faa8da9fe6983d2e0875149e0ec361eb8 100644
--- a/Source/devtools/front_end/ui/Popover.js
+++ b/Source/devtools/front_end/ui/Popover.js
@@ -40,13 +40,8 @@ WebInspector.Popover = function(popoverHelper)
this.element.className = "popover custom-popup-vertical-scroll custom-popup-horizontal-scroll"; // Override
this._containerElement = document.createElementWithClass("div", "fill popover-container");
- this._popupArrowElement = document.createElement("div");
- this._popupArrowElement.className = "arrow";
- this.element.appendChild(this._popupArrowElement);
-
- this._contentDiv = document.createElement("div");
- this._contentDiv.className = "content";
- this.element.appendChild(this._contentDiv);
+ this._popupArrowElement = this.element.createChild("div", "arrow");
+ this._contentDiv = this.element.createChild("div", "content");
this._popoverHelper = popoverHelper;
this._hideBound = this.hide.bind(this);
« no previous file with comments | « Source/devtools/front_end/ui/Checkbox.js ('k') | Source/devtools/front_end/ui/SidebarPane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698