Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Unified Diff: Source/devtools/front_end/resources/ResourcesPanel.js

Issue 362273002: DevTools: Reduce code via using document.createElementWithClass and document.createChild. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/resources/ResourcesPanel.js
diff --git a/Source/devtools/front_end/resources/ResourcesPanel.js b/Source/devtools/front_end/resources/ResourcesPanel.js
index 28ff59c9955e3bc6d37e9d3f9f8ca7b248099c79..ce78b2f86f87ea65149cb7750b1e3d82b0b42dce 100644
--- a/Source/devtools/front_end/resources/ResourcesPanel.js
+++ b/Source/devtools/front_end/resources/ResourcesPanel.js
@@ -826,23 +826,15 @@ WebInspector.BaseStorageTreeElement.prototype = {
this.listItemElement.classList.add(this._iconClasses[i]);
}
- var selectionElement = document.createElement("div");
- selectionElement.className = "selection";
- this.listItemElement.appendChild(selectionElement);
-
- if (!this._noIcon) {
- this.imageElement = document.createElement("img");
- this.imageElement.className = "icon";
- this.listItemElement.appendChild(this.imageElement);
- }
+ this.listItemElement.createChild("div", "selection");
+
+ if (!this._noIcon)
+ this.imageElement = this.listItemElement.createChild("img", "icon");
- this.titleElement = document.createElement("div");
- this.titleElement.className = "base-storage-tree-element-title";
- this._titleTextNode = document.createTextNode("");
- this.titleElement.appendChild(this._titleTextNode);
+ this.titleElement = this.listItemElement.createChild("div", "base-storage-tree-element-title");
+ this._titleTextNode = this.titleElement.createTextChild("");
this._updateTitle();
this._updateSubtitle();
- this.listItemElement.appendChild(this.titleElement);
},
get displayName()
@@ -875,14 +867,11 @@ WebInspector.BaseStorageTreeElement.prototype = {
return;
if (this._subtitleText) {
- if (!this._subtitleElement) {
- this._subtitleElement = document.createElement("span");
- this._subtitleElement.className = "base-storage-tree-element-subtitle";
- this.titleElement.appendChild(this._subtitleElement);
- }
+ if (!this._subtitleElement)
+ this._subtitleElement = this.titleElement.createChild("span", "base-storage-tree-element-subtitle");
this._subtitleElement.textContent = "(" + this._subtitleText + ")";
} else if (this._subtitleElement) {
- this.titleElement.removeChild(this._subtitleElement);
+ this._subtitleElement.remove();
delete this._subtitleElement;
}
},
@@ -1184,18 +1173,13 @@ WebInspector.FrameResourceTreeElement.prototype = {
WebInspector.BaseStorageTreeElement.prototype.onattach.call(this);
if (this._resource.type === WebInspector.resourceTypes.Image) {
- var previewImage = document.createElement("img");
- previewImage.className = "image-resource-icon-preview";
+ var iconElement = document.createElementWithClass("div", "icon");
+ var previewImage = iconElement.createChild("img", "image-resource-icon-preview");
this._resource.populateImageSource(previewImage);
-
- var iconElement = document.createElement("div");
- iconElement.className = "icon";
- iconElement.appendChild(previewImage);
this.listItemElement.replaceChild(iconElement, this.imageElement);
}
- this._statusElement = document.createElement("div");
- this._statusElement.className = "status";
+ this._statusElement = document.createElementWithClass("div", "status");
this.listItemElement.insertBefore(this._statusElement, this.titleElement);
this.listItemElement.draggable = true;
@@ -1223,14 +1207,13 @@ WebInspector.FrameResourceTreeElement.prototype = {
contextMenu.show();
},
+ /**
+ * @param {string} x
+ */
_setBubbleText: function(x)
{
- if (!this._bubbleElement) {
- this._bubbleElement = document.createElement("div");
- this._bubbleElement.className = "bubble";
- this._statusElement.appendChild(this._bubbleElement);
- }
-
+ if (!this._bubbleElement)
+ this._bubbleElement = this._statusElement.createChild("div", "bubble");
this._bubbleElement.textContent = x;
},
« no previous file with comments | « Source/devtools/front_end/common/DOMExtension.js ('k') | Source/devtools/front_end/source_frame/ImageView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698