Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2344)

Unified Diff: Source/devtools/front_end/source_frame/ImageView.js

Issue 362273002: DevTools: Reduce code via using document.createElementWithClass and document.createChild. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/source_frame/ImageView.js
diff --git a/Source/devtools/front_end/source_frame/ImageView.js b/Source/devtools/front_end/source_frame/ImageView.js
index 71199a0ac0efce6bf08f46ddc972476e4cdb137d..5682e6e747420b8d68f08356baa8d3faaea95d35 100644
--- a/Source/devtools/front_end/source_frame/ImageView.js
+++ b/Source/devtools/front_end/source_frame/ImageView.js
@@ -56,26 +56,14 @@ WebInspector.ImageView.prototype = {
if (this._container)
return;
- var imageContainer = document.createElement("div");
- imageContainer.className = "image";
- this.element.appendChild(imageContainer);
-
- var imagePreviewElement = document.createElement("img");
- imagePreviewElement.classList.add("resource-image-view");
- imageContainer.appendChild(imagePreviewElement);
+ var imageContainer = this.element.createChild("div", "image");
+ var imagePreviewElement = imageContainer.createChild("img", "resource-image-view");
imagePreviewElement.addEventListener("contextmenu", this._contextMenu.bind(this), true);
- this._container = document.createElement("div");
- this._container.className = "info";
- this.element.appendChild(this._container);
-
- var imageNameElement = document.createElement("h1");
- imageNameElement.className = "title";
- imageNameElement.textContent = this.resource.displayName;
- this._container.appendChild(imageNameElement);
+ this._container = this.element.createChild("div", "info");
+ this._container.createChild("h1", "title").textContent = this.resource.displayName;
- var infoListElement = document.createElement("dl");
- infoListElement.className = "infoList";
+ var infoListElement = document.createElementWithClass("dl", "infoList");
this.resource.populateImageSource(imagePreviewElement);
@@ -98,21 +86,11 @@ WebInspector.ImageView.prototype = {
infoListElement.removeChildren();
for (var i = 0; i < imageProperties.length; ++i) {
- var dt = document.createElement("dt");
- dt.textContent = imageProperties[i].name;
- infoListElement.appendChild(dt);
- var dd = document.createElement("dd");
- dd.textContent = imageProperties[i].value;
- infoListElement.appendChild(dd);
+ infoListElement.createChild("dt").textContent = imageProperties[i].name;
+ infoListElement.createChild("dd").textContent = imageProperties[i].value;
}
- var dt = document.createElement("dt");
- dt.textContent = WebInspector.UIString("URL");
- infoListElement.appendChild(dt);
- var dd = document.createElement("dd");
- var externalResource = true;
- dd.appendChild(WebInspector.linkifyURLAsNode(this.resource.url, undefined, undefined, externalResource));
- infoListElement.appendChild(dd);
-
+ infoListElement.createChild("dt").textContent = WebInspector.UIString("URL");
+ infoListElement.createChild("dd").appendChild(WebInspector.linkifyURLAsNode(this.resource.url, undefined, undefined, true /* externalResource */));
this._container.appendChild(infoListElement);
}
imagePreviewElement.addEventListener("load", onImageLoad.bind(this), false);
« no previous file with comments | « Source/devtools/front_end/resources/ResourcesPanel.js ('k') | Source/devtools/front_end/source_frame/SourceFrame.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698