[Android] Switch to DeviceUtils versions of file functions.

[Android] Switch to DeviceUtils versions of file functions.

This includes PushChangedFiles, FileExists, PullFile, ReadFile, and WriteFile.

BUG=267773
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281147

[jbudorick, 2014-06-27 20:06:09]

https://codereview.chromium.org/358993003/diff/20001/build/android/pylib/util...
File build/android/pylib/utils/reraiser_thread.py (left):

https://codereview.chromium.org/358993003/diff/20001/build/android/pylib/util...
build/android/pylib/utils/reraiser_thread.py:79: raise
Note that this no longer will now eat exceptions in the child thread. They will
still be reraised on the parent thread, though.

This prevents exceptions from being logged on the child thread in python's
threading module, e.g. the device_forwarder exceptions logged here:

http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14...

[jbudorick, 2014-06-27 20:07:51]

On 2014/06/27 20:06:09, jbudorick wrote:
>
https://codereview.chromium.org/358993003/diff/20001/build/android/pylib/util...
> File build/android/pylib/utils/reraiser_thread.py (left):
> 
>
https://codereview.chromium.org/358993003/diff/20001/build/android/pylib/util...
> build/android/pylib/utils/reraiser_thread.py:79: raise
> Note that this no longer will now eat exceptions in the child thread. They
will
> still be reraised on the parent thread, though.
> 
> This prevents exceptions from being logged on the child thread in python's
> threading module, e.g. the device_forwarder exceptions logged here:
> 
>
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14...

"Note that this no longer will now eat exceptions in the child thread."

->

"Note that this will now eat exceptions in the child thread."

Proofreading!

[cjhopman, 2014-06-27 20:20:49]

build/android/gyp lgtm

[tonyg, 2014-06-27 22:59:28]

lgtm

https://codereview.chromium.org/358993003/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
(right):

https://codereview.chromium.org/358993003/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:20:
util.AddDirToPythonPath(util.GetChromiumSrcDir(), 'build', 'android')
Why is this necessary? How did intent work without it?

[jbudorick, 2014-06-27 23:57:54]

On 2014/06/27 22:59:28, tonyg wrote:
> lgtm
> 
>
https://codereview.chromium.org/358993003/diff/20001/tools/telemetry/telemetr...
> File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
> (right):
> 
>
https://codereview.chromium.org/358993003/diff/20001/tools/telemetry/telemetr...
> tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:20:
> util.AddDirToPythonPath(util.GetChromiumSrcDir(), 'build', 'android')
> Why is this necessary? How did intent work without it?

This isn't actually necessary, but these pylib.device imports only work without
it because of import order. Everywhere that android_browser_backend is imported,
adb_commands has already been imported, so build/android/ is already in
sys.path.

It seems like poor form to rely on something being added to sys.path by another
file, though.

[tonyg, 2014-06-27 23:59:18]

On 2014/06/27 23:57:54, jbudorick wrote:
> On 2014/06/27 22:59:28, tonyg wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/358993003/diff/20001/tools/telemetry/telemetr...
> > File
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
> > (right):
> > 
> >
>
https://codereview.chromium.org/358993003/diff/20001/tools/telemetry/telemetr...
> >
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:20:
> > util.AddDirToPythonPath(util.GetChromiumSrcDir(), 'build', 'android')
> > Why is this necessary? How did intent work without it?
> 
> This isn't actually necessary, but these pylib.device imports only work
without
> it because of import order. Everywhere that android_browser_backend is
imported,
> adb_commands has already been imported, so build/android/ is already in
> sys.path.
> 
> It seems like poor form to rely on something being added to sys.path by
another
> file, though.

Thanks for the explanation. You're right about that. Still lgtm.

[frankf, 2014-06-28 00:21:35]

https://codereview.chromium.org/358993003/diff/20001/build/android/pylib/devi...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/358993003/diff/20001/build/android/pylib/devi...
build/android/pylib/device/device_utils.py:450: host that should be minimally
pushed to the device.
specify whether this is absolute and/or relative. Please do this for all such
args.

https://codereview.chromium.org/358993003/diff/20001/build/android/pylib/devi...
build/android/pylib/device/device_utils.py:501: the implementation switch?
move the TODO outside of docstring

[jbudorick, 2014-06-30 14:37:20]

https://codereview.chromium.org/358993003/diff/20001/build/android/pylib/devi...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/358993003/diff/20001/build/android/pylib/devi...
build/android/pylib/device/device_utils.py:450: host that should be minimally
pushed to the device.
On 2014/06/28 00:21:35, frankf wrote:
> specify whether this is absolute and/or relative. Please do this for all such
> args.

Done.

https://codereview.chromium.org/358993003/diff/20001/build/android/pylib/devi...
build/android/pylib/device/device_utils.py:501: the implementation switch?
On 2014/06/28 00:21:35, frankf wrote:
> move the TODO outside of docstring

Done.

[frankf, 2014-06-30 17:34:26]

lgtm

https://codereview.chromium.org/358993003/diff/40001/build/android/pylib/devi...
File build/android/pylib/device/device_utils_test.py (right):

https://codereview.chromium.org/358993003/diff/40001/build/android/pylib/devi...
build/android/pylib/device/device_utils_test.py:728: def
testPushChangedFiles_noHostPath(self):
In a future CL, you should spit out non-trivial device_util commands into their
own modules and tests.

[jbudorick, 2014-07-02 01:23:25]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-07-02 01:26:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/358993003/60001

[commit-bot: I haz the power, 2014-07-02 07:28:30]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-02 07:36:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 07:36:33]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[jbudorick, 2014-07-02 16:18:05]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-07-02 16:18:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/358993003/100001

[jbudorick, 2014-07-02 16:41:43]

The CQ bit was unchecked by jbudorick@chromium.org

[jbudorick, 2014-07-02 16:57:07]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-07-02 16:58:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/358993003/120001

[commit-bot: I haz the power, 2014-07-02 19:36:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-02 20:05:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 20:05:30]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[jbudorick, 2014-07-03 00:02:24]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-07-03 00:03:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/358993003/120001

[commit-bot: I haz the power, 2014-07-03 03:11:11]

Change committed as 281147